[WIP] Fix: Set Requeued condition for standalone workloads during admission check eviction #7673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sohankunkerkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
sohankunkerkar
force-pushed
the
fix-standalone-workload-requeue-condition
branch
3 times, most recently
from
ee17ecd to
06de27f
Compare
k8s-ci-robot
added
the
needs-rebase
sohankunkerkar
force-pushed
the
fix-standalone-workload-requeue-condition
branch
from
06de27f to
6c54a1c
Compare
k8s-ci-robot
removed
the
needs-rebase
sohankunkerkar
force-pushed
the
fix-standalone-workload-requeue-condition
branch
2 times, most recently
from
7db8b83 to
106125b
Compare
sohankunkerkar
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sohankunkerkar
force-pushed
the
fix-standalone-workload-requeue-condition
branch
from
106125b to
3210a84
Compare
… check eviction Previously, only job-managed workloads had the Requeued condition set during admission check eviction (via jobframework). Standalone workloads had no code path setting this condition. This change adds the condition to standalone workloads, ensuring consistent behavior between job-managed and standalone workloads. Signed-off-by: Sohan Kunkerkar <[email protected]>
sohankunkerkar
force-pushed
the
fix-standalone-workload-requeue-condition
branch
from
3210a84 to
3d8d8fb
Compare
Contributor
|
@sohankunkerkar: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only job-managed workloads had the Requeued condition set during admission check eviction (via jobframework). Standalone workloads had no code path setting this condition.
This change adds the condition to standalone workloads, ensuring consistent behavior between job-managed and standalone workloads.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #7620 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?