Fix: Set Requeued condition for standalone workloads during admission check eviction

Previously, only job-managed workloads had the Requeued condition set
during admission check eviction (via jobframework). Standalone workloads
had no code path setting this condition.

This change adds the condition to standalone workloads, ensuring
consistent behavior between job-managed and standalone workloads.

Author: sohankunkerkar

pkg/controller/core/workload_controller.go

@@ -543,7 +543,11 @@ func (r *WorkloadReconciler) reconcileCheckBasedEviction(ctx context.Context, wl
 	}
 	// at this point we know a Workload has at least one Retry AdmissionCheck
 	message := "At least one admission check is false"
-	if err := workload.Evict(ctx, r.client, r.recorder, wl, kueue.WorkloadEvictedByAdmissionCheck, message, "", r.clock); err != nil {
+	if err := workload.Evict(ctx, r.client, r.recorder, wl, kueue.WorkloadEvictedByAdmissionCheck, message, "", r.clock, workload.WithCustomPrepare(func() (*kueue.Workload, error) {
+		// Set Requeued=false to track eviction, matching jobframework behavior
+		workload.SetRequeuedCondition(wl, kueue.WorkloadEvictedByAdmissionCheck, "Evicted due to admission check retry", false)
+		return wl, nil
+	})); err != nil {
 		return false, err
 	}
 	return true, nil

pkg/controller/core/workload_controller_test.go

@@ -980,6 +980,12 @@ func TestReconcile(t *testing.T) {
 					Reason:  "AdmissionCheck",
 					Message: "At least one admission check is false",
 				}).
+				Condition(metav1.Condition{
+					Type:    "Requeued",
+					Status:  "False",
+					Reason:  "AdmissionCheck",
+					Message: "Evicted due to admission check retry",
+				}).
 				SchedulingStatsEviction(
 					kueue.WorkloadSchedulingStatsEviction{
 						Reason: kueue.WorkloadEvictedByAdmissionCheck,

pkg/workload/workload.go

@@ -863,7 +863,11 @@ func PropagateResourceRequests(w *kueue.Workload, info *Info) bool {
 // If strict is true, resourceVersion will be part of the patch.
 func admissionStatusPatch(w *kueue.Workload, wlCopy *kueue.Workload) {
 	wlCopy.Status.Admission = w.Status.Admission.DeepCopy()
-	wlCopy.Status.RequeueState = w.Status.RequeueState.DeepCopy()
+	// Only include RequeueState if it's set, to avoid clobbering values
+	// set by other controllers.
+	if w.Status.RequeueState != nil {
+		wlCopy.Status.RequeueState = w.Status.RequeueState.DeepCopy()
+	}
 	if wlCopy.Status.Admission != nil {
 		// Clear ResourceRequests; Assignment.PodSetAssignment[].ResourceUsage supercedes it
 		wlCopy.Status.ResourceRequests = []kueue.PodSetRequest{}