Fix: Set Requeued condition for standalone workloads during admission check eviction

Previously, only job-managed workloads had the Requeued condition set
during admission check eviction (via jobframework). Standalone workloads
had no code path setting this condition.

This change adds the condition to standalone workloads, ensuring
consistent behavior between job-managed and standalone workloads.

Signed-off-by: Sohan Kunkerkar <[email protected]>

Author: sohankunkerkar

pkg/controller/core/workload_controller.go

@@ -205,17 +205,6 @@ func (r *WorkloadReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 		return ctrl.Result{}, nil
 	}
 
-	if requeueAt := workload.NeedsRequeueAtUpdate(&wl, r.clock); requeueAt != nil {
-		err := workload.PatchAdmissionStatus(ctx, r.client, &wl, r.clock, func(wl *kueue.Workload) (bool, error) {
-			if wl.Status.RequeueState == nil {
-				wl.Status.RequeueState = &kueue.RequeueState{}
-			}
-			log.V(2).Info("At least one admission check set a retry time", "requeueAt", requeueAt, "current", wl.Status.RequeueState.RequeueAt)
-			workload.SetRequeueState(wl, *requeueAt, false)
-			return true, nil
-		})
-		return reconcile.Result{}, client.IgnoreNotFound(err)
-	}
 	if features.Enabled(features.DynamicResourceAllocation) && workload.Status(&wl) == workload.StatusPending &&
 		workload.HasDRA(&wl) {
 		workload.AdjustResources(ctx, r.client, &wl)
@@ -601,7 +590,15 @@ func (r *WorkloadReconciler) reconcileCheckBasedEviction(ctx context.Context, wl
 	}
 	// at this point we know a Workload has at least one Retry AdmissionCheck
 	message := "At least one admission check is false"
-	if err := workload.Evict(ctx, r.client, r.recorder, wl, kueue.WorkloadEvictedByAdmissionCheck, message, "", r.clock); err != nil {
+	// Calculate the retry time from admission checks before eviction resets them.
+	maxRetryTime := workload.GetMaxRetryTime(wl)
+	if err := workload.Evict(ctx, r.client, r.recorder, wl, kueue.WorkloadEvictedByAdmissionCheck, message, "", r.clock, workload.WithCustomPrepare(func(wl *kueue.Workload) {
+		// Set Requeued=false to track eviction, matching jobframework behavior
+		workload.SetRequeuedCondition(wl, kueue.WorkloadEvictedByAdmissionCheck, "Evicted due to admission check retry", false)
+		if !maxRetryTime.IsZero() {
+			workload.SetRequeueState(wl, maxRetryTime, false)
+		}
+	})); err != nil {
 		return false, err
 	}
 	return true, nil

pkg/controller/core/workload_controller_test.go

@@ -981,6 +981,12 @@ func TestReconcile(t *testing.T) {
 					Reason:  "AdmissionCheck",
 					Message: "At least one admission check is false",
 				}).
+				Condition(metav1.Condition{
+					Type:    "Requeued",
+					Status:  "False",
+					Reason:  "AdmissionCheck",
+					Message: "Evicted due to admission check retry",
+				}).
 				SchedulingStatsEviction(
 					kueue.WorkloadSchedulingStatsEviction{
 						Reason: kueue.WorkloadEvictedByAdmissionCheck,