[BETA] Allow zero-amount expenses - ROUND 5 #79197

Gonals · 2026-01-09T12:18:02Z

IMPORTANT. READ BEFORE REVERTING
This PR is likely to cause bugs. For this reason, most of its functionality is behind a beta. Before reverting, please, make sure the bugs will actually be a problem for our users. If the bug is behind the beta, it is not a blocker. When in doubt, ping @Gonals

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/557844
PROPOSAL:

Tests

Ok, there are a bunch of things here. All in newDot, in an account in the zero_expenses beta (or any expensify account):

Confirm you can create a manual expense with zero as the amount. No violation should show.
Confirm you can create a distance expense with zero as the distance. No violation should show.
Confirm you can edit an existing manual expense to set the amount to zero. No violation should show.
Confirm you can edit an existing receipt expense to set the amount to zero. No violation should show (beyond the amount being different to the smartscanned amount when relevant).
Confirm you can edit an existing distance expense to set the distance to zero. No violation should show.
Confirm you can edit an existing distance expense to set the amount to zero. No violation should show (beyond the amount being different to the calculated one when relevant).
Confirm you can edit amounts/distances back to non-zero for all the above.
Confirm that, when you create a zero-expense in the self-DM with no merchant, the merchant defaults to 'Expense', not '(none)' (it won't display, so check onyx)
Zero amounts are still not allowed for splits
Zero amounts are not allowed for P2P requests
Zero amounts are allowed for self-DM
Zero amounts are not allowed for accounts not on the beta

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

No real UI changes

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2026-01-09T12:18:37Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-09T12:26:12Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`83.76% <ø> (ø)`
src/components/MoneyReportHeader.tsx	`0.00% <ø> (ø)`
...ents/ReportActionItem/TransactionPreview/index.tsx	`83.87% <100.00%> (ø)`
src/components/TransactionItemRow/index.tsx	`87.12% <100.00%> (ø)`
src/libs/DistanceRequestUtils.ts	`81.34% <100.00%> (ø)`
src/libs/SearchUIUtils.ts	`60.18% <100.00%> (ø)`
src/libs/TransactionPreviewUtils.ts	`72.43% <100.00%> (+1.37%)`	⬆️
src/libs/Violations/ViolationsUtils.ts	`69.66% <100.00%> (ø)`
src/libs/actions/IOU/index.ts	`67.66% <100.00%> (-0.21%)`	⬇️
src/libs/actions/Policy/Member.ts	`72.75% <ø> (ø)`
... and 19 more
... and 2 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ca1e3dfc6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx

src/components/ReportActionItem/TransactionPreview/index.tsx

src/components/ReportActionItem/MoneyRequestView.tsx

trjExpensify

5th time is a charm! 👍

Gonals · 2026-01-09T17:26:16Z

@QichenZhu, this is ready for review. It is basically the same PR you just reviewed with some minor changes to fix the bugs

trjExpensify · 2026-01-12T17:57:35Z

@QichenZhu do you have an ETA on reviewing this PR?

QichenZhu · 2026-01-12T23:32:18Z

I'll provide feedback in 8 hours.

QichenZhu · 2026-01-13T07:33:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
There are many console errors not related to this PR that I reported before.
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native_578decd9.mp4

Android: mWeb Chrome

android-web.mp4

iOS: HybridApp

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mp4

QichenZhu · 2026-01-13T09:31:53Z

NAB: #77238 (comment)

cannot edit a non-zero distance to zero in offline mode.

77238-bug-5.mov

melvin-bot · 2026-01-13T09:36:10Z

🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #79439.

Valforte · 2026-01-13T18:07:52Z

@Gonals can you fix the conflict?

Gonals · 2026-01-14T15:00:14Z

@Gonals can you fix the conflict?

All ready!

Valforte

LGTM

OSBotify · 2026-01-15T13:39:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-15T17:46:41Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.3-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

DylanDylann · 2026-01-15T17:55:40Z

src/libs/TransactionUtils/index.ts

+let allBetas: OnyxEntry<Beta[]>;
+Onyx.connectWithoutView({
+    key: ONYXKEYS.BETAS,
+    callback: (value) => (allBetas = value),
+});
+


@Gonals It looks like we don't agree to use connectWithoutView here

Discussed here: #70139 (comment)

cc @tgolen @luacmartins

lanitochka17 · 2026-01-15T19:51:12Z

This PR is failing because of issue ##79716

The issue is reproducible in: Web

Bug7050353_1768500392122.9.1.mp4

lanitochka17 · 2026-01-15T20:23:02Z

This PR is failing because of issue ##79722

The issue is reproducible in: Web

Bug7050378_1768501562035.Recording__1274.1.mp4

OSBotify · 2026-01-16T23:16:17Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.3-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "[CP Staging] Revert 79085 & 77238"

6ca1e3d

Gonals self-assigned this Jan 9, 2026

Gonals requested review from a team as code owners January 9, 2026 12:18

melvin-bot bot requested review from cristipaval and trjExpensify and removed request for a team January 9, 2026 12:18

chatgpt-codex-connector bot reviewed Jan 9, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReportPreview/index.tsx Show resolved Hide resolved

src/components/ReportActionItem/TransactionPreview/index.tsx Show resolved Hide resolved

src/components/ReportActionItem/MoneyRequestView.tsx Show resolved Hide resolved

trjExpensify previously approved these changes Jan 9, 2026

View reviewed changes

Gonals added 5 commits January 9, 2026 15:02

fix split bug

1edad79

fix p2p zero editing

06b7819

fix distance message

3c81726

Prevent moving zero expenses to IOU

2b51660

better split errors fix

4abb336

Gonals dismissed trjExpensify’s stale review via 4abb336 January 9, 2026 15:26

Gonals changed the title ~~Allow zero-amount expenses - ROUND 5~~ [BETA] Allow zero-amount expenses - ROUND 5 Jan 9, 2026

Gonals added 2 commits January 9, 2026 16:37

Merge branch 'main' into revert-79145-arosiclair-revert-79085-77238

9034806

prettier

91e2f36

Gonals requested a review from a team as a code owner January 9, 2026 15:48

Gonals added 2 commits January 9, 2026 17:09

new prettier

a65bdf3

better split fix

5aeee80

Gonals requested a review from QichenZhu January 9, 2026 17:25

Valforte previously approved these changes Jan 13, 2026

View reviewed changes

conflicts

3c00173

Gonals dismissed Valforte’s stale review via 3c00173 January 14, 2026 13:59

Add import

9711cef

conflicts

4a760ca

Valforte approved these changes Jan 15, 2026

View reviewed changes

Valforte merged commit dd5bd5d into main Jan 15, 2026
33 checks passed

Valforte deleted the revert-79145-arosiclair-revert-79085-77238 branch January 15, 2026 13:30

OSBotify mentioned this pull request Jan 15, 2026

Deploy Checklist: New Expensify 2026-01-15 #79701

Closed

65 tasks

DylanDylann reviewed Jan 15, 2026

View reviewed changes

This was referenced Jan 15, 2026

[Due for payment 2026-01-27] Expense - Report field in IOU expense shows IOU, Report field in self DM is blank #79709

Closed

Distance - Rate changes from $0.70 / mile to $0.725 / mile #79715

Closed

lanitochka17 mentioned this pull request Jan 15, 2026

Expense - Expense does not appear in merge expense list after changing amount to non-zero #79716

Open

7 tasks

This was referenced Jan 15, 2026

Distance - Merchant field is shown instead of Distance and Rate field when distance is 0 #79719

Open

[$250] Expense - No violation when editing an existing receipt expense to a zero amount #79722

Closed

This was referenced Jan 16, 2026

Split in group - Fields lead to "Not here", Split button is presented in a scan split #79742

Closed

[Due for payment 2026-02-03] Scan split - Wrong violation on the scan split preview when it fails (Missing merchant) #79743

Open

jponikarchuk mentioned this pull request Jan 20, 2026

[$250] Expense - No result shows up when email is entered when creating Scan expense from FAB #80002

Open

7 tasks

nkdengineer mentioned this pull request Jan 22, 2026

[$250] Expense - Imported contacts do not appear in the contact list #80023

Open

7 tasks

mitarachim mentioned this pull request Jan 23, 2026

Expense - Time expense with 0.00 amount can be submitted for p2p expense #80344

Open

7 tasks

Gonals mentioned this pull request Jan 26, 2026

Remove BETA_ZERO_EXPENSES #80511

Open

54 tasks

jponikarchuk mentioned this pull request Jan 27, 2026

[$250] Distance - After changing distance to 0 and changing rate, Amount does not retain 0.00 value #80610

Open

7 tasks

[BETA] Allow zero-amount expenses - ROUND 5 #79197

[BETA] Allow zero-amount expenses - ROUND 5 #79197

Uh oh!

Conversation

Gonals commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 9, 2026

Uh oh!

codecov bot commented Jan 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Gonals commented Jan 9, 2026

Uh oh!

trjExpensify commented Jan 12, 2026

Uh oh!

QichenZhu commented Jan 12, 2026

Uh oh!

QichenZhu commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Jan 13, 2026

Uh oh!

melvin-bot bot commented Jan 13, 2026

Uh oh!

Valforte commented Jan 13, 2026

Uh oh!

Gonals commented Jan 14, 2026

Uh oh!

Valforte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 15, 2026

Uh oh!

DylanDylann Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

lanitochka17 commented Jan 15, 2026

Uh oh!

lanitochka17 commented Jan 15, 2026

Uh oh!

OSBotify commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Gonals commented Jan 9, 2026 •

edited

Loading

codecov bot commented Jan 9, 2026 •

edited by github-actions bot

Loading

QichenZhu commented Jan 13, 2026 •

edited

Loading