Expense - Time expense with 0.00 amount can be submitted for p2p expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79197
Email or phone of affected tester (no customers): applausetester+sdodjssods@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account.
• Time tracking is enabled on OD.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Time.
4. Create a time expense.
5. Open the time expense.
6. Click Reports > Remove from report.
7. Go to self DM.
8. Open the unreported time expense.
9. Click on the report header > Submit it to someone.
10. Select a user.
11. On confirm page, click Rate.
12. Enter 0 and save it.
13. Click Create expense.

Expected Result:

User should not be allowed to submit 0.00 time expense for p2p expense, according to #79197

Actual Result:

User can submit 0.00 time expense for p2p expense

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7055457_1769076924822.15.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Time expense with 0.00 amount can be submitted for p2p expense

What is the root cause of that problem?

We are not passing isP2P prop to MoneyRequestAmountForm here

App/src/pages/iou/request/step/IOURequestStepTimeRate.tsx

Lines 82 to 84 in 6e6f87c

	<MoneyRequestAmountForm
	isEditing
	amount={transaction?.comment?.units?.rate}

Then isP2P will be false here and isAmountInvalid will return true then the logic to show invalid amount error will be skipped

App/src/pages/iou/MoneyRequestAmountForm.tsx

Lines 172 to 174 in 6e6f87c

	if (!currentAmount.length || (!isTaxAmountForm && isAmountInvalid(currentAmount, iouType, isP2P, isBetaEnabled(CONST.BETAS.ZERO_EXPENSES)))) {
	setFormError(translate('iou.error.invalidAmount'));
	return;

What changes do you think we should make in order to solve the problem?

We should pass isP2P prop

const isP2P = isParticipantP2P(transaction?.participants?.at(0));

 <MoneyRequestAmountForm 
     isEditing 
     amount={transaction?.comment?.units?.rate} 
     isP2P={isP2P}

Similar issues happens on IOURequestStepAmount
For IOURequestStepAmount, we are trying to use chat report to get the first participant when we are trying to determine if the chat is P2P. When a user is submitting to a new user chat report will be undefined and isP2P will be false. We should fallback to using using transaction when report is undefined

isP2P={isParticipantP2P(getMoneyRequestParticipantsFromReport(chatReportForP2PCheck, currentUserPersonalDetails.accountID).at(0) ?? transaction?.participants?.at(0))}

We should check other places where similar issue happens and fix them.

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 443 in 6e6f87c

isP2P={isParticipantP2P(getMoneyRequestParticipantsFromReport(chatReportForP2PCheck, currentUserPersonalDetails.accountID).at(0))}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.