Skip to content

fix: prevent signed/unsigned mix in TcpConn::isend #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VecherVhatuX wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −4
Open

fix: prevent signed/unsigned mix in TcpConn::isend #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb15800
fix: prevent signed/unsigned mix in TcpConn::isend
VecherVhatuX Sep 5, 2025
34586ab
remove comments
VecherVhatuX Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions handy/conn.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,14 @@ ssize_t TcpConn::isend(const char *buf, size_t len) {
while (len > sended) {
ssize_t wd = writeImp(channel_->fd(), buf + sended, len - sended);
trace("channel %lld fd %d write %ld bytes", (long long) channel_->id(), channel_->fd(), wd);

if (wd > 0) {
sended += wd;
sended += static_cast<size_t>(wd);
continue;
} else if (wd == -1 && errno == EINTR) {
continue;
} else if (wd == -1 && (errno == EAGAIN || errno == EWOULDBLOCK)) {
if (!channel_->writeEnabled()) {
channel_->enableWrite(true);
}
if (!channel_->writeEnabled()) channel_->enableWrite(true);
break;
} else {
error("write error: channel %lld fd %d wd %ld %d %s", (long long) channel_->id(), channel_->fd(), wd, errno, strerror(errno));
Expand Down