fix: prevent signed/unsigned mix in TcpConn::isend#116
Open
VecherVhatuX wants to merge 2 commits intoyedf2:masterfrom
Open
fix: prevent signed/unsigned mix in TcpConn::isend#116VecherVhatuX wants to merge 2 commits intoyedf2:masterfrom
VecherVhatuX wants to merge 2 commits intoyedf2:masterfrom
Conversation
|
刘德聪,已经收到你的邮件,请你放心
祝你生活愉快,笑口常开
|
Author
|
@ggandycong, could you please tell whether this PR is ok or should we just close the PR? |
|
刘德聪,已经收到你的邮件,请你放心
祝你生活愉快,笑口常开
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
TcpConn::isend, the variablesendedis size_t (unsigned), whilewdreturned from writeImp is ssize_t (signed). The original codesended += wd;mixes signed and unsigned types. Ifwdis negative (e.g., -1 on error), adding it tosendedwould convert it to a large positive value, potentially causing wraparound or logic errors.This is a classic case of CWE-190: Integer Overflow or Wraparound
(https://cwe.mitre.org/data/definitions/190.html).
Fix:
wdtosendedwhenwd > 0Importance:
sended