Replace features task with spec task#568
Merged
etagwerker merged 3 commits intowhitesmith:mainfrom Apr 26, 2026
Merged
Conversation
- Rewrote all cucumber features as minitest/spec specs - Added spec task, and removed features task - Updated CI scripts to run spec instead of features - Stopped bundling Cucumber
Contributor
Author
|
I hope we can kick th tires on this early and get thins sorted out so it's solid while we land any more major changes for 5.1. |
There was a problem hiding this comment.
Pull request overview
This PR replaces Cucumber-based integration tests with Minitest/Spec specs, removing the Cucumber dependency entirely. All existing feature scenarios are faithfully ported to the new spec format using Aruba for command execution.
Changes:
- Rewrote all Cucumber feature files (options, minimum_score, rake_task) as Minitest/Spec integration specs with a shared
IntegrationTestHelpermodule - Removed Cucumber dependency from gemspec, Rakefile, and CI configuration; added a new
specRake task - Cleaned up
.rubocop.ymlby removing Cucumber-specific exclusions and adding one for the new helper
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/integration_test_helper.rb | New shared helper module providing Aruba-based command runners and sample file creators |
| test/integration/options_spec.rb | Spec replacement for options.feature (bad option, version, help) |
| test/integration/minimum_score_spec.rb | Spec replacement for minimum_score.feature (score thresholds) |
| test/integration/rake_task_spec.rb | Spec replacement for rake_task.feature (paths, name, verbose, minimum-score, fail_on_error) |
| Rakefile | Replaced Cucumber task with Minitest spec task; updated default task |
| rubycritic.gemspec | Removed cucumber development dependency |
| .rubocop.yml | Removed Cucumber exclusion, added integration_test_helper exclusion |
| .github/workflows/main.yml | Updated CI step to run rake spec instead of cucumber |
| CHANGELOG.md | Added changelog entry for the migration |
| features/* (deleted) | Removed all Cucumber feature and step definition files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- In CI, rename Features jobs to Spec - Configure Aruba timeout to 30 seconds, as had been the case in the features. - Fix creation of empty.rb in minimum_score_spec.rb, and then fix the spec to not false-negative on the correctly generated higher score.
- Exclude Style/OneClassPerFile in offending files. - When building ast_node_children in lib/rubycritic/analysers/helpers/ast_node.rb, use grep instead of select with a kind check (Style/SelectByKind) - When generating hash in RubyCritic::AnalysisSummary, use to_h directly (Style/ReduceToHash)
faisal
force-pushed
the
replace_features_with_specs
branch
from
a4e2acc to
f7f540c
Compare
Contributor
Author
|
This should be ready for re-review, and possibly merging. |
Contributor
Author
|
@etagwerker what do you think the next step should be here? |
etagwerker
approved these changes
Apr 26, 2026
Collaborator
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@faisal looks good, thank you!
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at replacing our Cucumber-managed features with Minitest/Spec-managed specs. This implements #565.
Check list: