Replace features task with spec task (#568)

* Replace features task with spec task

- Rewrote all cucumber features as minitest/spec specs
- Added spec task, and removed features task
- Updated CI scripts to run spec instead of features
- Stopped bundling Cucumber

* Fix issues identified by GitHub copilot review

- In CI, rename Features jobs to Spec
- Configure Aruba timeout to 30 seconds, as had been the case in the features.
- Fix creation of empty.rb in minimum_score_spec.rb, and then fix the spec to not false-negative on the correctly generated higher score.

* Catch up with rubocop cop updates

- Exclude Style/OneClassPerFile in offending files.
- When building ast_node_children in lib/rubycritic/analysers/helpers/ast_node.rb, use grep instead of select with a kind check (Style/SelectByKind)
- When generating hash in RubyCritic::AnalysisSummary, use to_h directly (Style/ReduceToHash)

Author: faisal

.github/workflows/main.yml

@@ -20,7 +20,7 @@ jobs:
           paths_ignore: '["**/README.md", "**/docs/**", "**/CHANGELOG.md"]'
           do_not_skip: '["pull_request", "workflow_dispatch", "schedule"]'
 
-  Features:
+  Specs:
     needs: pre_job # skip duplicates
     if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
     runs-on: ubuntu-latest
@@ -47,8 +47,8 @@ jobs:
           bundler-cache: true
           cache-version: 1
         continue-on-error: ${{ matrix.experimental }}
-      - name: Run Cucumber
-        run: bundle exec cucumber features --format progress --color
+      - name: Run feature specs
+        run: bundle exec rake spec
         continue-on-error: ${{ matrix.experimental }}
 
   Rubocop:

.rubocop.yml

@@ -17,11 +17,6 @@ Gemspec/DevelopmentDependencies:
   Exclude:
     - 'rubycritic.gemspec'
 
-Layout/BlockAlignment:
-  Enabled: false
-  Exclude:
-    - 'features/step_definitions/rake_task_steps.rb'
-
 Layout/LineLength:
   Max: 120
 
@@ -58,6 +53,7 @@ Metrics/BlockLength:
 Metrics/MethodLength:
   Exclude:
     - 'lib/rubycritic/configuration.rb'
+    - 'test/integration/integration_test_helper.rb'
 
 Naming/RescuedExceptionsVariableName:
   Exclude:
@@ -76,6 +72,13 @@ Style/Documentation:
 Style/HashSyntax:
   EnforcedShorthandSyntax: either
 
+Style/OneClassPerFile:
+  Exclude:
+    - 'lib/rubycritic/analysers/helpers/ast_node.rb'
+    - 'test/analysers_test_helper.rb'
+    - 'test/fakefs_helper.rb'
+    - 'test/test_helper.rb'
+
 Style/OpenStructUse:
   Exclude:
     - 'test/lib/rubycritic/generators/turbulence_test.rb'

CHANGELOG.md

@@ -5,6 +5,8 @@
 * [CHORE] ...
 * [FEATURE] ...
 
+* [CHANGE] Replace all Cucumber features with Minitest/Spec specs (by [@faisal][])
+
 # v5.0.0 / 2026-01-26 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.12.0...v5.0.0)
 
 * [CHORE] Bump byebug dependency (by [@faisal][])

Rakefile

@@ -3,7 +3,6 @@
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'rubocop/rake_task'
-require 'cucumber/rake/task'
 require 'reek/rake/task'
 require 'rubycritic/rake_task'
 
@@ -13,8 +12,10 @@ Rake::TestTask.new do |task|
   task.pattern = 'test/**/*_test.rb'
 end
 
-Cucumber::Rake::Task.new(:features) do |t|
-  t.cucumber_opts = %w[features --format progress --color]
+Rake::TestTask.new(:spec) do |task|
+  task.libs.push 'lib'
+  task.libs.push 'test'
+  task.pattern = 'test/**/*_spec.rb'
 end
 
 RuboCop::RakeTask.new
@@ -25,4 +26,4 @@ RubyCritic::RakeTask.new do |task|
   task.paths = FileList['lib/**/*.rb']
 end
 
-task default: %i[test features reek rubocop]
+task default: %i[test spec reek rubocop]