Guard layout-review HTTP actions against unknown action names#87
Merged
thomaswantstobeaskeleton merged 1 commit intocodex/update-software-icon-and-readmefrom May 2, 2026
Conversation
3edb300
into
codex/update-software-icon-and-readme
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ActionTypeset, which previously caused downstream grouping code to raiseKeyError.Description
actionvalues before constructingReviewActioninui/mainwindow.pyby importingActionTypeandget_argsand addingVALID_REVIEW_ACTIONS = set(get_args(ActionType)).actionnames (with aLOGGER.debugentry) instead of passing them on to downstream logic.block_indexas anintand continue to skip negative indices; preserve behavior for valid actions.ui/mainwindow.pyaround the HTTP provider response parsing and_build_review_result_from_provider_actionslogic.Testing
python -m compileall -f -q ui/mainwindow.py, which completed (bytecode compiled) for the modified file.python -c "import ui.mainwindow; print('import ok')", which failed due toImportError: libGL.so.1: cannot open shared object filefrom OpenCV in this environment; this runtime failure is unrelated to the patch and prevents a full import smoke-test here.Codex Task