Skip to content

[6.3] MandatoryDestroyHoisting: ignore type-dependent operands when computing the liverange of a value #87563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eeckstein wants to merge 1 commit into
base: release/6.3
Choose a base branch
from
+30 −1
Open

[6.3] MandatoryDestroyHoisting: ignore type-dependent operands when computing the liverange of a value #87563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SwiftCompilerSources/Sources/Optimizer/FunctionPasses/MandatoryDestroyHoisting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ private struct Liverange {
prunedLiverange.insert(contentsOf: nonDestroyingUsers)

self.fullLiverange = InstructionRange(for: value, context)
fullLiverange.insert(contentsOf: value.users)
fullLiverange.insert(contentsOf: value.uses.ignoreTypeDependence.users)

self.context = context
}
Expand Down
29 changes: 29 additions & 0 deletions test/SILOptimizer/mandatory-destroy-hoisting.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,3 +476,32 @@ bb0(%0 : @owned $C):
%10 = tuple ()
return %10
}

protocol P: AnyObject {}

// CHECK-LABEL: sil [ossa] @type_dependent_operand_outside_liverange :
// CHECK: bb2:
// CHECK-NEXT: destroy_value %2
// CHECK: } // end sil function 'type_dependent_operand_outside_liverange'
sil [ossa] @type_dependent_operand_outside_liverange : $@convention(thin) (@in_guaranteed any P) -> () {

bb0(%0 : $*any P):
%1 = load [copy] %0
%2 = open_existential_ref %1 to $@opened("093C97B4-11DD-11F1-AC30-1A9AD1B1CD90", any P) Self
cond_br undef, bb1, bb2

bb1:
%4 = alloc_stack $@opened("093C97B4-11DD-11F1-AC30-1A9AD1B1CD90", any P) Self
store %2 to [init] %4
%6 = apply undef<@opened("093C97B4-11DD-11F1-AC30-1A9AD1B1CD90", any P) Self>(%4) : $@convention(thin) <τ_0_0 where τ_0_0 : P> (@in τ_0_0) -> ()
dealloc_stack %4
br bb3

bb2:
destroy_value %2
br bb3

bb3:
%11 = tuple ()
return %11
}