[6.3] MandatoryDestroyHoisting: ignore type-dependent operands when computing the liverange of a value#87563
Open
eeckstein wants to merge 1 commit intoswiftlang:release/6.3from
Open
Conversation
Contributor
eeckstein
commented
Feb 27, 2026
eeckstein
commented
- Explanation: Type-dependent operands can appear outside the liverange of a value and therefore must be ignored. This bug caused MandatoryDestroyHoisting to insert wrong destroys. This change fixes a SIL verification error and/or a mis-compile.
- Risk: Very low. It's a 1-line change to ignore type-dependent operands for liverange computation
- Testing: Tested by lit tests.
- Issue: rdar://170510052
- Reviewer: @meg-gupta
- Main branch PR: MandatoryDestroyHoisting: ignore type-dependent operands when computing the liverange of a value #87562
…ng the liverange of a value Type-dependent operands can appear outside the liverange of a value and therefore must be ignored. This bug caused MandatoryDestroyHoisting to insert wrong destroys. Fixes a SIL verification error and/or a mis-compile rdar://170510052
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.