Skip to content

Chore: Make IOS create separate compile_commands.json #9122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wisniewskij wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Chore: Make IOS create separate compile_commands.json #9122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01d3169
Change scripts
wisniewskij Mar 18, 2026
75392a2
Remove debu
wisniewskij Mar 18, 2026
7f641f2
Revert changes
wisniewskij Mar 18, 2026
70b3c9d
Combine both compile_command.jsons
wisniewskij Mar 18, 2026
1391293
Fix syntax error in clangd-generate script
wisniewskij Mar 18, 2026
ce8fee5
Delete dis from the codebase
wisniewskij Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/fabric-example/ios/Podfile.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 17 additions & 5 deletions packages/react-native-reanimated/scripts/clangd-generate-xcode-metadata.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
#!/bin/bash

COMPILE_COMMANDS_PATH="../../../compile_commands.json"
COMPILE_COMMANDS_REANIMATED_PATH="../../../packages/react-native-reanimated/compile_commands.json"
COMPILE_COMMANDS_WORKLETS_PATH="../../../packages/react-native-worklets/compile_commands.json"
COMPILATION_DATABASE_PATH="**/CompilationDatabase"

echo "[" >$COMPILE_COMMANDS_PATH
for f in **/CompilationDatabase/*.json; do cat "$f" >>$COMPILE_COMMANDS_PATH; done
echo "]" >>$COMPILE_COMMANDS_PATH

echo "Generated clangd metadata."
out="$COMPILE_COMMANDS_REANIMATED_PATH"

printf "[\n" > "$out"
cat $COMPILATION_DATABASE_PATH/*.json >> "$out"

sed '$ s/,$//' "$out" > "$out.tmp"
Copy link
Collaborator

@tjzel tjzel Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simply remove the last character instead of seding? Or is it the simplest approach to remove the last character?

mv "$out.tmp" "$out"

printf "]" >> "$out"

cp "$COMPILE_COMMANDS_REANIMATED_PATH" "$COMPILE_COMMANDS_WORKLETS_PATH"


echo "Generated clangd metadata."
Copy link
Collaborator

@tjzel tjzel Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing newline

Suggested change
echo "Generated clangd metadata."
echo "Generated clangd metadata."

8 changes: 7 additions & 1 deletion packages/react-native-worklets/RNWorklets.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ worklets_assert_new_architecture_enabled($new_arch_enabled)

ios_min_version = '13.4'

# Directory in which data for further processing for clangd will be stored.
compilation_metadata_dir = "CompilationDatabase"
# We want generate the metadata only within the monorepo of Reanimated.
compilation_metadata_generation_flag = $config[:is_reanimated_example_app] ? "-gen-cdb-fragment-path #{compilation_metadata_dir}" : ''


feature_flags = $worklets_config[:feature_flags_flag]
version_flags = "-DWORKLETS_VERSION=#{package['version']} -DREACT_NATIVE_MINOR_VERSION=#{$worklets_config[:react_native_minor_version]}"
worklets_profiling_flag = ENV['IS_WORKLETS_PROFILING'] ? '-DWORKLETS_PROFILING' : ''
Expand Down Expand Up @@ -75,7 +81,7 @@ Pod::Spec.new do |s|
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
"GCC_PREPROCESSOR_DEFINITIONS[config=*Debug*]" => "$(inherited) #{hermes_debug_hidden_flags}",
"GCC_PREPROCESSOR_DEFINITIONS[config=*Release*]" => "$(inherited)",
"OTHER_CFLAGS" => "$(inherited) #{feature_flags} #{version_flags} #{worklets_profiling_flag} #{fetch_preview_flag} #{hermes_v1_flag}",
"OTHER_CFLAGS" => "$(inherited) #{feature_flags} #{version_flags} #{compilation_metadata_generation_flag} #{worklets_profiling_flag} #{fetch_preview_flag} #{hermes_v1_flag}",
}
s.xcconfig = {
"HEADER_SEARCH_PATHS" => [
Expand Down
Loading