Chore: Make IOS create separate compile_commands.json#9122
Open
wisniewskij wants to merge 6 commits intomainfrom
Open
Chore: Make IOS create separate compile_commands.json#9122wisniewskij wants to merge 6 commits intomainfrom
wisniewskij wants to merge 6 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently if we build for IOS, we receive singular compile_commands.json in the root of the package. This file doesn't include compile commands for worklets.
This PR changes that -- both worklets and reanimated are combined into a single compile_commands.json which is then copied into worklet's and reanimate's folders in packages.
Test plan
🚀