feat: Listing data source #4205
Conversation
|
Integration tests cancelled for 885d9788fc85aecff4ed64f01092273e56289878 |
sfc-gh-jcieslak
force-pushed
the
listing-data-source
branch
from
a3f7b12 to
d916e42
Compare
|
Integration tests cancelled for a3f7b122949bd4fbfbbbddb4c7c91c02d58431f6 |
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Account-level tests success for 885d9788fc85aecff4ed64f01092273e56289878 |
|
Account-level tests success for d916e4230f81c4597b70ed618c8527fd006910b2 |
|
Integration tests failure for d916e4230f81c4597b70ed618c8527fd006910b2 |
pkg/acceptance/bettertestspoc/config/datasourcemodel/gen/datasource_schema_def.go
Outdated
Show resolved
Hide resolved
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Integration tests failure for 7b1fd0bd4578877a82f9dc86320f65e90d83370f |
# Conflicts: # MIGRATION_GUIDE.md # docs/index.md
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Account-level tests success for 7c633a5730728d88806b1243b9a52211853b109b |
|
Integration tests failure for 7c633a5730728d88806b1243b9a52211853b109b |
# Conflicts: # MIGRATION_GUIDE.md
# Conflicts: # MIGRATION_GUIDE.md
sfc-gh-jcieslak
had a problem deploying
to
test
GitHub Actions
Failure
|
Account-level tests failure for a5aa26d9cd5d6c569394e7e25014863eed6f41e9 |
|
Integration tests success for a5aa26d9cd5d6c569394e7e25014863eed6f41e9 |
# Conflicts: # MIGRATION_GUIDE.md
sfc-gh-jcieslak
dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-asawicki
via
f4e4773
|
Integration tests cancelled for f4e47735871b0d133583c85caea40d5471ad78df |
|
Account-level tests cancelled for f4e47735871b0d133583c85caea40d5471ad78df |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: true, | ||
| Description: "Runs DESC LISTING for each listing returned by SHOW LISTINGS. The output of describe is saved to the description field. By default this value is set to true.", |
There was a problem hiding this comment.
Documentation inconsistency that could confuse users: The description states the output is "saved to the description field" but it's actually saved to the describe_output field (as defined on line 38). This should be corrected to:
Description: "Runs DESC LISTING for each listing returned by SHOW LISTINGS. The output of describe is saved to the describe_output field. By default this value is set to true.",| Description: "Runs DESC LISTING for each listing returned by SHOW LISTINGS. The output of describe is saved to the description field. By default this value is set to true.", | |
| Description: "Runs DESC LISTING for each listing returned by SHOW LISTINGS. The output of describe is saved to the describe_output field. By default this value is set to true.", |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Add listing data source: