Adjust task documentation

Author: sfc-gh-jcieslak

pkg/acceptance/bettertestspoc/config/datasourcemodel/listings_model_ext.go

@@ -1,24 +1,22 @@
 package datasourcemodel
 
 import (
-    tfconfig "github.com/hashicorp/terraform-plugin-testing/config"
+	tfconfig "github.com/hashicorp/terraform-plugin-testing/config"
 )
 
 func (l *ListingsModel) WithLimit(rows int) *ListingsModel {
-    return l.WithLimitValue(
-        tfconfig.ObjectVariable(map[string]tfconfig.Variable{
-            "rows": tfconfig.IntegerVariable(rows),
-        }),
-    )
+	return l.WithLimitValue(
+		tfconfig.ObjectVariable(map[string]tfconfig.Variable{
+			"rows": tfconfig.IntegerVariable(rows),
+		}),
+	)
 }
 
 func (l *ListingsModel) WithRowsAndFrom(rows int, from string) *ListingsModel {
-    return l.WithLimitValue(
-        tfconfig.ObjectVariable(map[string]tfconfig.Variable{
-            "rows": tfconfig.IntegerVariable(rows),
-            "from": tfconfig.StringVariable(from),
-        }),
-    )
+	return l.WithLimitValue(
+		tfconfig.ObjectVariable(map[string]tfconfig.Variable{
+			"rows": tfconfig.IntegerVariable(rows),
+			"from": tfconfig.StringVariable(from),
+		}),
+	)
 }
-
-

pkg/schemas/listing_details.go

@@ -5,8 +5,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-// TODO: Validate
-
 // DescribeListingSchema represents output of DESCRIBE LISTING for a single Listing.
 var DescribeListingSchema = map[string]*schema.Schema{
 	"global_name":                     {Type: schema.TypeString, Computed: true},

pkg/testacc/data_source_listings_acceptance_test.go

@@ -145,7 +145,7 @@ func TestAcc_Listings_CompleteUseCase(t *testing.T) {
 					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.owner")),
 					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.owner_role_type")),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.state", "PUBLISHED")),
-					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.share")),
+					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.share", share.ID().Name())),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.application_package", "")),
 					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.manifest_yaml")),
 					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.listing_terms")),
@@ -160,7 +160,7 @@ func TestAcc_Listings_CompleteUseCase(t *testing.T) {
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.data_preview", "")),
 					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.published_on")),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.comment", comment)),
-					assert.Check(resource.TestCheckResourceAttrSet(listingsModel.DatasourceReference(), "listings.0.describe_output.0.revisions")),
+					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.revisions", "PUBLISHED")),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.target_accounts", "")),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.regions", "")),
 					assert.Check(resource.TestCheckResourceAttr(listingsModel.DatasourceReference(), "listings.0.describe_output.0.refresh_schedule", "")),