Change default value of verbose parameter for LeverageScore within sketchdata#10145
Open
Liuy12 wants to merge 2 commits intosatijalab:mainfrom
Open
Change default value of verbose parameter for LeverageScore within sketchdata#10145Liuy12 wants to merge 2 commits intosatijalab:mainfrom
Liuy12 wants to merge 2 commits intosatijalab:mainfrom
Conversation
Change default value of verbose parameter for LeverageScore to use the supplied verbose. Otherwise, user will have no idea of the process especially when the sample size is large.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default verbosity behavior in the SketchData function to properly propagate the user-specified verbose parameter to the LeverageScore function, ensuring users receive progress updates when processing large sample sizes.
Key Changes:
- Modified
SketchDatafunction to pass through theverboseparameter instead of hardcoding it toFALSE
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change default value of verbose parameter for LeverageScore to use the supplied verbose. Otherwise, user will have no idea of the process especially when the sample size is large.