Handle duplicate mesh file names in the conversion tool#171
Open
eholum-nasa wants to merge 6 commits intoros-controls:mainfrom
Open
Handle duplicate mesh file names in the conversion tool#171eholum-nasa wants to merge 6 commits intoros-controls:mainfrom
eholum-nasa wants to merge 6 commits intoros-controls:mainfrom
Conversation
Collaborator
Author
|
@esheetz-nasa tagging you here if you have the time to take a look? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 73.66% 73.66%
=======================================
Files 12 12
Lines 2761 2761
Branches 284 284
=======================================
Hits 2034 2034
Misses 608 608
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have simulations that are running multiple types of UR arms (ur5e + ur10e) which we want to use the conversion tool on. The problem is that UR has commonly named mesh files across their robots, https://github.com/UniversalRobots/Universal_Robots_ROS2_Description/tree/rolling/meshes, so when converting we end up with duplicated asset names and the output gets overwritten.
To get around this, we propose adding a suffix when duplicate mesh files are found. We just add
_Nand increment as needed. I'm not sure if there's a better way of handling this that would actually work in all cases (like somehow deduping based on file structure), so this is pretty simple and solves it if using the conversion script.Updated and did a little clean up of the tools docs while I was at it. Sorry to nitpick about markdown formatting... The only thing that actually changed in the docs is adding a note about the added underscore, updating the lidar example since it was out of date, and changing a reference to use a relative path.