Skip to content

DFBUGS-3637:[release-4.17] controllers: skip reconcile of rook-ceph-mon secret#435

Merged
openshift-merge-bot[bot] merged 1 commit intored-hat-storage:release-4.17from
leelavg:skip-creating-mon-secret
Jul 30, 2025
Merged

DFBUGS-3637:[release-4.17] controllers: skip reconcile of rook-ceph-mon secret#435
openshift-merge-bot[bot] merged 1 commit intored-hat-storage:release-4.17from
leelavg:skip-creating-mon-secret

Conversation

@leelavg
Copy link
Contributor

@leelavg leelavg commented Jul 22, 2025

a 4.16 provider can send this secret to 4.17 client, skip creation.

@leelavg leelavg changed the title controllers: skip reconcile of rook-ceph-mon secret DFBUGS-3637:[release-4.17] controllers: skip reconcile of rook-ceph-mon secret Jul 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jul 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2025

@leelavg: This pull request references [Jira Issue DFBUGS-3637](https://issues.redhat.com//browse/DFBUGS-3637), which is invalid:

  • expected the bug to target the "odf-4.17.10" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

a 4.16 provider can send this secret to 4.17 client, if it is already owned by storageclient, delete it and rook will generate new one or else skip creation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@leelavg
Copy link
Contributor Author

leelavg commented Jul 22, 2025

client can upgrade first than provider due to https://issues.redhat.com/browse/DFBUGS-2502

@leelavg
Copy link
Contributor Author

leelavg commented Jul 22, 2025

/hold

@leelavg leelavg force-pushed the skip-creating-mon-secret branch from a7ee37b to cf3bdd9 Compare July 24, 2025 07:12
a 4.16 provider can send this secret to 4.17 client, skip creation.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@leelavg leelavg force-pushed the skip-creating-mon-secret branch from cf3bdd9 to 52e34f6 Compare July 24, 2025 07:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2025

@leelavg: This pull request references [Jira Issue DFBUGS-3637](https://issues.redhat.com//browse/DFBUGS-3637), which is invalid:

  • expected the bug to target the "odf-4.17.10" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

a 4.16 provider can send this secret to 4.17 client, skip creation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 24, 2025

@leelavg LGTM but I do want to make sure we have an agreed opinion on #435 (comment) before merging.

@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 24, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agarwal-mudit agarwal-mudit added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed do-not-merge/hold jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jul 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a65c9f1 into red-hat-storage:release-4.17 Jul 30, 2025
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 30, 2025

@leelavg: [Jira Issue DFBUGS-3637](https://issues.redhat.com//browse/DFBUGS-3637): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-3637](https://issues.redhat.com//browse/DFBUGS-3637) has been moved to the MODIFIED state.

Details

In response to this:

a 4.16 provider can send this secret to 4.17 client, skip creation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants