Skip to content

DFBUGS-3690:[release-4.16]: provider: do not send mon secret to client#3383

Closed
leelavg wants to merge 1 commit intored-hat-storage:release-4.16from
leelavg:stop-mon-secret-dist
Closed

DFBUGS-3690:[release-4.16]: provider: do not send mon secret to client#3383
leelavg wants to merge 1 commit intored-hat-storage:release-4.16from
leelavg:stop-mon-secret-dist

Conversation

@leelavg
Copy link
Contributor

@leelavg leelavg commented Jul 22, 2025

there is no requirement to send mon-secret to client and due to the change in content client.admin keyring is being overwritten at client end when both rook-op and client-op runs in same namespace.

there is no requirement to send mon-secret to client and due to the
change in content client.admin keyring is being overwritten at client
end when both rook-op and client-op runs in same namespace.

Signed-off-by: Leela Venkaiah G <lgangava@ibm.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jul 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2025

@leelavg: This pull request references [Jira Issue DFBUGS-3637](https://issues.redhat.com//browse/DFBUGS-3637), which is invalid:

  • expected the bug to target the "odf-4.16.12" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

there is no requirement to send mon-secret to client and due to the change in content client.admin keyring is being overwritten at client end when both rook-op and client-op runs in same namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg
Once this PR has been reviewed and has the lgtm label, please assign blaineexe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Jul 23, 2025

/hold
thinking to fix in 4.17 directly on client-op.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2025
@agarwal-mudit agarwal-mudit changed the title DFBUGS-3637:[release-4.16]: provider: do not send mon secret to client DFBUGS-3690:[release-4.16]: provider: do not send mon secret to client Jul 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025

@leelavg: This pull request references [Jira Issue DFBUGS-3690](https://issues.redhat.com//browse/DFBUGS-3690), which is invalid:

  • expected the bug to target the "odf-4.16.12" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

there is no requirement to send mon-secret to client and due to the change in content client.admin keyring is being overwritten at client end when both rook-op and client-op runs in same namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agarwal-mudit
Copy link
Member

Closed because of red-hat-storage/ocs-client-operator#435

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025

@leelavg: This pull request references [Jira Issue DFBUGS-3690](https://issues.redhat.com//browse/DFBUGS-3690). The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

there is no requirement to send mon-secret to client and due to the change in content client.admin keyring is being overwritten at client end when both rook-op and client-op runs in same namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-important jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants