Continue Overture support: POIs, Places, Airports#579
Merged
Conversation
Add Overture `theme=base / type=infrastructure / subtype=airport` runway and taxiway linestrings to the roads layer, matching OSM parity where `aeroway=runway` appears with `kind=aeroway`, `kind_detail=runway`, `min_zoom=9`. - Add `overtureAerowayKindsIndex` mapping Overture class=runway/taxiway/taxilane to kind=aeroway with appropriate kind_detail values - Extend `processOverture()` with a new branch for base/infrastructure features, emitting line geometries at min_zoom=9 (runway) or min_zoom=10 (taxiway) - Add two Overture unit tests: kind_aeroway_fromRunwayClass and kind_aeroway_fromTaxiwayClass Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Fix populationFallback in processOverture: use 0 when population > 0, so cities/towns with real population data no longer get forced into fallback zoom levels (was hardcoded to 1, causing city minZoom=8 instead of 7) - Add wikidata lookup block to processOverture mirroring the OSM path, so entries in places.csv (Q62, Q16553, Q169943, etc.) now override minZoom and populationRank for Overture locality features - Output wikidata attribute on Overture features that have it - Add failing-first tests for SF (Q62→minZoom=2), San Jose (Q16553→4), San Mateo (Q169943→6), Saratoga (Q927163→7, pop present no fallback) - Update testOaklandCity: min_zoom 9→8 (population present, no fallback) - Use real Overture UUIDs from Oakland-visualtests.parquet in all new tests Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
migurski
force-pushed
the
migurski/continue-overture
branch
2 times, most recently
from
9bdfcfe to
99f8914
Compare
Drop features below confidence 0.65 (junk tier: ~127k features dominated by real estate listings, beauty salons, ATMs from uncertain sources). Within the remaining features, use confidence to break sort key ties so higher-confidence POIs win label collision resolution at the same zoom. Sort key: minZoom * 1000 - (int)(confidence * 100), so confidence=0.99 scores 99 points lower (higher priority) than confidence=0.65. Tests updated: websiteQid_ineligibleCategory_dropped and websiteQid_lowConfidence_dropped now correctly expect zero features. kind_nationalPark_fromBasicCategory switched to Pinnacles National Park (4d619bc0, confidence=0.917) since the previous Alcatraz fixture (814b8a78, confidence=0.639) falls below the new cutoff. Prompt: "Let's bring more Overture confidence into POI rendering: make higher-confidence POIs higher rendering priority, and simply omit ones below 0.65 (junk tier)" Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
migurski
changed the title
….java Let's turn the repetition there into a new private method called getZoomsPops that results in minZoom, populationRank, etc. assigned. Does getZoomsPops() need both sf and sf2 args, or can it get by with just sf2? Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
bdon
approved these changes
Mar 31, 2026
bdon
reviewed
Mar 31, 2026
|
|
||
| public void processOverture(SourceFeature sf, FeatureCollector features) { | ||
| if ("base".equals(sf.getString("theme")) && "infrastructure".equals(sf.getString("type"))) { | ||
| if (!"airport".equals(sf.getString("subtype"))) |
Member
There was a problem hiding this comment.
The motivation of the matcher object was to reduce this procedural special-casing in the java method bodies, but it could be unavoidable for now
Collaborator
Author
There was a problem hiding this comment.
Agreed, though in this case the "theme" matching might best fit outside the matcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR assisted by Claude Code + Sonnet 4
Current
HEADtiles visible at https://protomaps.dev/~migurski/Oakland-visualtests-0ef1b8a.pmtilesZoom 4+ places, OSM at left and this PR at right:
Zoom 12+ airports, OSM at left and this PR at right:
POI selection: