Commit cd50047
authored
Continue Overture support: POIs, Places, Airports (#579)
* Added some Oakland-specific visual test areas
* Add Overture Airport Runways to Roads Layer
Add Overture `theme=base / type=infrastructure / subtype=airport` runway and
taxiway linestrings to the roads layer, matching OSM parity where
`aeroway=runway` appears with `kind=aeroway`, `kind_detail=runway`, `min_zoom=9`.
- Add `overtureAerowayKindsIndex` mapping Overture class=runway/taxiway/taxilane
to kind=aeroway with appropriate kind_detail values
- Extend `processOverture()` with a new branch for base/infrastructure features,
emitting line geometries at min_zoom=9 (runway) or min_zoom=10 (taxiway)
- Add two Overture unit tests: kind_aeroway_fromRunwayClass and
kind_aeroway_fromTaxiwayClass
* Fix Overture places at low zoom levels; use real Overture UUIDs in tests
- Fix populationFallback in processOverture: use 0 when population > 0,
so cities/towns with real population data no longer get forced into
fallback zoom levels (was hardcoded to 1, causing city minZoom=8
instead of 7)
- Add wikidata lookup block to processOverture mirroring the OSM path,
so entries in places.csv (Q62, Q16553, Q169943, etc.) now override
minZoom and populationRank for Overture locality features
- Output wikidata attribute on Overture features that have it
- Add failing-first tests for SF (Q62→minZoom=2), San Jose (Q16553→4),
San Mateo (Q169943→6), Saratoga (Q927163→7, pop present no fallback)
- Update testOaklandCity: min_zoom 9→8 (population present, no fallback)
- Use real Overture UUIDs from Oakland-visualtests.parquet in all new tests
* Use Overture confidence for POI filtering and rendering priority
Drop features below confidence 0.65 (junk tier: ~127k features dominated
by real estate listings, beauty salons, ATMs from uncertain sources).
Within the remaining features, use confidence to break sort key ties so
higher-confidence POIs win label collision resolution at the same zoom.
Sort key: minZoom * 1000 - (int)(confidence * 100), so confidence=0.99
scores 99 points lower (higher priority) than confidence=0.65.
Tests updated: websiteQid_ineligibleCategory_dropped and
websiteQid_lowConfidence_dropped now correctly expect zero features.
kind_nationalPark_fromBasicCategory switched to Pinnacles National Park
(4d619bc0, confidence=0.917) since the previous Alcatraz fixture
(814b8a78, confidence=0.639) falls below the new cutoff.
Prompt: "Let's bring more Overture confidence into POI rendering: make
higher-confidence POIs higher rendering priority, and simply omit ones
below 0.65 (junk tier)"
* Extract getZoomsPops() to remove duplicated zoom/rank logic in Places.java1 parent bfb7fd7 commit cd50047
File tree
9 files changed
+386
-54
lines changed- app/src
- tiles/src
- main/java/com/protomaps/basemap
- layers
- test/java/com/protomaps/basemap/layers
9 files changed
+386
-54
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
2 | 114 | | |
3 | 115 | | |
4 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| |||
Lines changed: 45 additions & 47 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | 272 | | |
277 | 273 | | |
278 | | - | |
279 | 274 | | |
280 | 275 | | |
281 | 276 | | |
282 | 277 | | |
283 | 278 | | |
284 | 279 | | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
308 | 285 | | |
309 | 286 | | |
310 | 287 | | |
| |||
379 | 356 | | |
380 | 357 | | |
381 | 358 | | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
| 359 | + | |
389 | 360 | | |
390 | 361 | | |
391 | 362 | | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | 363 | | |
398 | 364 | | |
399 | 365 | | |
400 | 366 | | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
408 | 372 | | |
409 | 373 | | |
410 | 374 | | |
| |||
418 | 382 | | |
419 | 383 | | |
420 | 384 | | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
421 | 389 | | |
422 | 390 | | |
423 | 391 | | |
| |||
428 | 396 | | |
429 | 397 | | |
430 | 398 | | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
431 | 429 | | |
432 | 430 | | |
433 | 431 | | |
| |||
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
562 | 562 | | |
563 | 563 | | |
564 | 564 | | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
565 | 572 | | |
566 | 573 | | |
567 | 574 | | |
| |||
581 | 588 | | |
582 | 589 | | |
583 | 590 | | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
584 | 595 | | |
585 | 596 | | |
586 | 597 | | |
| |||
593 | 604 | | |
594 | 605 | | |
595 | 606 | | |
596 | | - | |
| 607 | + | |
| 608 | + | |
597 | 609 | | |
598 | 610 | | |
599 | 611 | | |
| |||
Lines changed: 35 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
222 | 233 | | |
223 | 234 | | |
224 | 235 | | |
| |||
505 | 516 | | |
506 | 517 | | |
507 | 518 | | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
508 | 543 | | |
509 | 544 | | |
510 | 545 | | |
| |||
0 commit comments