fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example"#148
Conversation
…vant associations when displaying CoastersCollector example" as illustrated in moosetechnology/Famix#1070
|
@tinchodias Hello Martin, do you have the rights to approve this PR ? |
I assume the Roassal team needs to review also if the proposal PR is in line with the intended / preferred semantics involved or the proposal needs review in that perspective |
yes I can! I will check |
|
Is this change backwards compatible? in a fast read I just did, it looks like you extracted code to a hook. I imagine this way you can override in your subclasses with custom shapes? |
|
Hi @tinchodias, I will review the error and review the integration of the proposal made. Please reject the PR. Thanks in advance, |
…associations is overriden in FamixUMLRoassalDescriptor intention of moosetechnology/Famix#1070); FamixUMLRoassalDescriptor enherits from RSUMLClassDescriptor; intention of moosetechnology/Famix#1070 is to show associations (without cardinality for now); reviewing examples indicate Roassal my not have been intended to represent a Full UML Class Diagram. My intent approaching to visualize a Full UML Class Diagram. I managed to have all tests in "RSUMLClassBuilderTest" and all examples in "RSUMLExamples" except "example08HierarchyPacker" due to "RPackage" being undeclared.
|
added additional commit that should do away with all errors (see commit message) |
|
I apologize for not having reviewed the testcases and examples before the previous commit. |
|
Thanks @bart-at-qqdatafruits! For some reason, I had to click on a "Run workflow" button, else the CI doesn't run automatically. Maybe this is your first contribution to the project, and after the first merge, the CI will run automatically. The error in Pharo 12 is unrelated (see #141) |
fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example" as illustrated in moosetechnology/Famix#1070