Skip to content

Comments

fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example"#148

Open
bart-at-qqdatafruits wants to merge 2 commits intopharo-graphics:Pharo14from
bart-at-qqdatafruits:qqdatafruits/FamixUMLRoassalBackend_associations
Open

fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example"#148
bart-at-qqdatafruits wants to merge 2 commits intopharo-graphics:Pharo14from
bart-at-qqdatafruits:qqdatafruits/FamixUMLRoassalBackend_associations

Conversation

@bart-at-qqdatafruits
Copy link

fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example" as illustrated in moosetechnology/Famix#1070

…vant associations when displaying CoastersCollector example" as illustrated in moosetechnology/Famix#1070
@NicolasAnquetil
Copy link

NicolasAnquetil commented Jan 29, 2026

@tinchodias Hello Martin, do you have the rights to approve this PR ?

@bart-at-qqdatafruits
Copy link
Author

@tinchodias Hello Martin, do you have the rights to approve this PR ?

I assume the Roassal team needs to review also if the proposal PR is in line with the intended / preferred semantics involved or the proposal needs review in that perspective

@tinchodias
Copy link
Contributor

@tinchodias Hello Martin, do you have the rights to approve this PR ?

yes I can! I will check

@tinchodias
Copy link
Contributor

Is this change backwards compatible? in a fast read I just did, it looks like you extracted code to a hook. I imagine this way you can override in your subclasses with custom shapes?

@bart-at-qqdatafruits
Copy link
Author

Hi @tinchodias,

I will review the error and review the integration of the proposal made.

Please reject the PR.

Thanks in advance,

…associations is overriden in FamixUMLRoassalDescriptor intention of moosetechnology/Famix#1070);  FamixUMLRoassalDescriptor enherits from RSUMLClassDescriptor; intention of  moosetechnology/Famix#1070 is to show associations (without cardinality for now); reviewing examples indicate Roassal my not have been intended to represent a Full UML Class Diagram. My intent approaching to visualize a Full UML Class Diagram. I managed to have all tests in "RSUMLClassBuilderTest" and all examples in "RSUMLExamples" except "example08HierarchyPacker" due to "RPackage" being undeclared.
@bart-at-qqdatafruits
Copy link
Author

added additional commit that should do away with all errors (see commit message)
note that maybe more importantly is the question if the intent of Roassal-UML is intended to implement an UML Class Diagram, allowing to add associations.

@bart-at-qqdatafruits
Copy link
Author

I apologize for not having reviewed the testcases and examples before the previous commit.
I will have a look at example08HierarchyPacker as it still fails on Pharo13 build 723.
Normally tests on Pharo13 and Pharo14 should have failed too.
I will review the log of the Pharo12 tests to see how I can improve further testing from my side

@tinchodias
Copy link
Contributor

tinchodias commented Feb 3, 2026

Thanks @bart-at-qqdatafruits!

For some reason, I had to click on a "Run workflow" button, else the CI doesn't run automatically.

Maybe this is your first contribution to the project, and after the first merge, the CI will run automatically.

The error in Pharo 12 is unrelated (see #141)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants