FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example (using image Moose12-Pharo12)

[bart-at-qqdatafruits]

Hi,

I examined https://github.com/badetitou/CoastersCollector to have a look at the modelling capabilities of Moose.

The approach is explained at https://modularmoose.org/blog/2021-02-04-coasters/

The CI section of the example repository uses FamixUMLPlantUMLBackend for visualization https://github.com/badetitou/CoastersCollector/tree/master/ci

As Plant seems to be hidden behind a cookie-wall I tried FamixUMLRoassalBackend, a solution more native to pharo.

I assumed the visualization of CoasterCollection using the following
|documentor| documentor := FamixUMLDocumentor new. documentor model: CCModel; excludeClasses: { CCModel. CMModel. WModel. WEntity . CCEntity . CCTEntityCreator }; generate. FamixUMLRoassalBackend new export: documentor umlEntities.
would show the association relations (lines) between Couster, country, Creator and Shape, similar to the below picture

My observation is that these lines where not there.

My question to the user-community and maintainers is:

• do you agree or disagree that the lines should be there
• do you agree it would be useful to have associations visualized in addition to aggregation and inheritance

I will try to share my attempt to add the lines (without indication of cardinality) as a pull request.

I think the associations would be interesting to have to assist in conceptual and logical modelling

[NicolasAnquetil]

Thanks for the contribution.
From a cursory look, I would say I agree, but I will have a more in-depth look in the course of the week

[bart-at-qqdatafruits]

to reproduce the original issue (lines missing on associations)

1. get the moose image "Moose12-Pharo12"
2. add repository https://github.com/badetitou/CoastersCollector
3. loads its baseline (default) with Montecello
4. open a playground
5. Do It on the following code excerpt:

|documentor| documentor := FamixUMLDocumentor new. documentor model: CCModel; excludeClasses: { CCModel. CMModel. WModel. WEntity . CCEntity }; generate. FamixUMLRoassalBackend new export: documentor umlEntities.
6. observe is a drawing in the inspector similar to

7. expected was as similar drawing in the inspector similar to

remarks

• the prior mention of "CCTEntityCreator" is nice to have but can only be applied when having re-issued CoasterCollectorMetamodelGenerator generate.
• reproducing this issue in moose image "Moose12-Pharo13" fails the inspector with the following error
  "Error while creating the inspector. Debug it by executing the following:" | collector pragma context | collector := StInspectionCollector on: self. pragma := (RSCanvas lookupSelector: #inspectorCanvas) pragmas first. context := collector basicContextFromPragma: pragma. context basicNewInspectionPresenter
  I assume the latter is a different and unrelated issue

[bart-at-qqdatafruits]

I attempted to cover the issue
using 2 pull requests:

• 1 on Famix: Qqdatafruits/famix uml roassal backend associations #1071
• 1 on Roassal: fix: proposal to solve "FamixUMLRoassalBackend does not show all relevant associations when displaying CoastersCollector example" pharo-graphics/Roassal#148

I will take some more time this week to review how to remove the other commits from the Famix pull-request provided

the intention was to only impact the following messages

• Famix-UMLDocumentor::FamixUMLRoassalDescriptor>>associations
• Roassal-UML::RSAbstractUMLClassRenderer>>associationShape
• Roassal-UML::RSAbstractUMLClassRenderer>>simpleLineShape
• Roassal-UML::RSAbstractUMLClassRenderer>>renderAssociations

[bart-at-qqdatafruits]

Thanks for the contribution. From a cursory look, I would say I agree, but I will have a more in-depth look in the course of the week

Thanks @NicolasAnquetil

I hope the information added helps to clarify, reproduce, advise orient for a solution

[bart-at-qqdatafruits]

changed #1071 by #1075

[NicolasAnquetil]

Hello
I had a look at the issue: The problem is that Roassal UML (RSUMLClassBuilder) does not support Associations.
It only offers Aggregation and Composition

FamixUMLRoassalDescriptor that you are proposing to fix is controlled by RSUMLClassBuilder which does not call #associations because it does not handle them.
So the fix would not work without modifying Roassal itself.

I implemented what you propose as a new #composition (which RSUMLClassBuilder does call)

The result is the following:

which is not quite entirely satisfying

We can get around this without modifying Roassal itself to better represent class diagrams

[NicolasAnquetil]

BTW, are you aware that there is also a FamixUMLMermaidBackend that similarly to the PlantUML backend export a script that mermaid process

[bart-at-qqdatafruits]

Hello I had a look at the issue: The problem is that Roassal UML (RSUMLClassBuilder) does not support Associations. It only offers Aggregation and Composition

FamixUMLRoassalDescriptor that you are proposing to fix is controlled by RSUMLClassBuilder which does not call #associations because it does not handle them. So the fix would not work without modifying Roassal itself.

I implemented what you propose as a new #composition (which RSUMLClassBuilder does call)

The result is the following:
which is not quite entirely satisfying

We can get around this without modifying Roassal itself to better represent class diagrams

I understand your proposed workaround.
Question remains what is FamixUMLRoassalDescriptor and RSUMLClassBuilder are intended for
This in relation to other Descriptors
Ideally there is a functional consistency of definition and capability