fix: try deleting the XBlock from draft-branch if not in published

[marslanabdulrauf]

Related Ticket

https://github.com/mitodl/hq/issues/9456 (MIT Internal)

Description

This pull request improves the logic for deleting course blocks in the delete_item method of the split.py modulestore. It specifically addresses scenarios where a subsection has been moved to another section in the draft branch, ensuring that deletions are handled correctly across both the main/publish and draft branches.

Enhanced block deletion logic:

• If a block to be deleted does not exist in the original structure, the code now checks the draft branch for its presence. If found, deletion proceeds using the draft structure; if not, a clearer error is raised. This helps handle cases where subsections are moved in drafts and then deleted.

Steps to Reproduce

1. Go to a studio outline for a course
2. Create a new subsection inside of any section
3. Move the subsection to a different Section
4. Attempt to delete the new subsection
5. Page will show the "are you sure" dialogue box, and will then show the "deleting" message at the bottom of the screen, but then an error message "cannot save changes" will appear at the top of the screen
6. Go to the three dot menu of the new subsection and click "publish;" approve the publish action
7. Attempt to delete again - this time the deletion will be successful

Testing instructions

1. Checkout to this branch and repeat the steps from above
2. Sub-section should be deleted without any issue

[openedx-webhooks]

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[farhan]

@ttqureshi and I have reviewed the PR and tested it.

We successfully reproduced the issue and tested its fix. Changes seem alright, though will recommend to have second +1 from someone who has better domain knowledge of the split mongo.

@openedx/axim-aximprovements team has better in depth knowledge of Built In XBlocks within Xmodule.