chatapi: remove assistant-mode execution branches#9779
Draft
Saby-Bishops wants to merge 1 commit intomasterfrom
Draft
chatapi: remove assistant-mode execution branches#9779Saby-Bishops wants to merge 1 commit intomasterfrom
Saby-Bishops wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
chatapi/src/utils/chat-assistant.utils.tsand deleted assistant-specific runtime/thread/run streaming logic, so both streaming and non-streaming flows call provider chat completions directly.assistantfield fromaiChat,chat, andchatNoSavesignatures and updated all call sites to stop accepting/forwarding the assistant flag (chatapi/src/utils/chat.utils.ts,chatapi/src/services/chat.service.ts,chatapi/src/index.ts).chatapi/src/config/ai-providers.config.tsand removed theassistanttype fromchatapi/src/models/chat.model.ts.chatapi/src/utils/chat-helpers.utils.ts).Testing
cd chatapi && npm run buildand the TypeScript build completed successfully.cd chatapi && npm run lintand ESLint reported no errors (one prior unused-var warning was resolved).Note: This change removes a user-visible AI mode; obtain PM/owner sign-off before deployment due to high product risk.
Codex Task