-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Update realsense2 to 2.56.5 #48694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update realsense2 to 2.56.5 #48694
Conversation
|
I give up , I gave it my all , hours of debugging understanding of CI/CD pipelines were for nothing I guess. |
Do you need help with this? |
Yes I do need but also when I didn't patch rsutils the arm64-ox builds were compiling just fine but after adding the patch fix for rsutils other components broke but some were working just fine , I'm confused I dont know how to even do this??? |
dg0yt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch is clearly malformed. It looks like you manually edited the previous patch by removing some context lines. But this needs more work. I would recommed using tools:
- unpack the sources,
- make the a git repo,
- apply patches with
git apply(strict) orpatch -p1(relaxed) - fix the issues
- produce an update diff e.g. with
git diff.
| @@ -0,0 +1,21 @@ | |||
| --- a/third-party/rsutils/src/control-c-handler.cpp | |||
| +++ b/third-party/rsutils/src/control-c-handler.cpp | |||
| @@ -1,4 +1,5 @@ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 original lines, 3 lines after the change.
| @@ -1,4 +1,5 @@ | |
| @@ -1,2 +1,3 @@ |
|
|
||
| --- a/third-party/rsutils/src/special-folder.cpp | ||
| +++ b/third-party/rsutils/src/special-folder.cpp | ||
| @@ -1,6 +1,7 @@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 original lines, 5 lines after the change.
| @@ -1,6 +1,7 @@ | |
| @@ -1,4 +1,5 @@ |
|
|
||
| --- a/third-party/rsutils/src/network-adapter-watcher.cpp | ||
| +++ b/third-party/rsutils/src/network-adapter-watcher.cpp | ||
| @@ -1,6 +1,8 @@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,6 +1,8 @@ | |
| @@ -1,2 +1,4 @@ |
| #include <chrono> | ||
| #include <regex> | ||
| +#include <thread> | ||
| +#include <cstring> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No line break at end of the file. Bad editor, e.g. VS Code.
| +#include <cstring> | |
| +#include <cstring> |
|
Ok , I'll check and implement the changes as you've requested. |
Update realsense2 port to version 2.56.5.
Refresh upstream source tarball and updated SHA512 hash.
Update firmware download SHA to match new release contents.
Regenerate version entry using vcpkg x-add-version.
Ensured all existing patches remain compatible with the new version.