Remove unused audit log file rotation settings from docs

[Combs7th]

Remove four unused audit log file rotation settings from documentation to reflect Mattermost server v11.4+ behavior.

Engineering PR mattermost/mattermost#35170 removes these settings from ExperimentalAuditSettings:

• FileMaxSizeMB
• FileMaxAgeDays
• FileMaxBackups
• FileCompress

File rotation for audit logs is now configured via AdvancedLoggingJSON.

Closes #8769

Generated with Claude Code

[Combs7th]

@hanzei - Tagging you for dev review. Do the changes above look accurate? If so, I'll tag Eric for editor review.

[github-actions]

Newest code from mattermost has been published to preview environment for Git SHA f141ce0

[amyblais]

@Combs7th This is also scheduled for v11.6 (April release).

[hanzei]

Thanks!

[hanzei]

Are you sure that you can set the queue side without advanced logging?

[hanzei]

We don't do telemetry any longer. Can we just drop the file?

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[Combs7th]

@claude - Please revise the docs update based on the PR evidence and developer feedback.

Before drafting:

• Treat the engineering PR as the source of truth.
• Note that the PR removes five unused ExperimentalAuditSettings fields, not four:
• FileMaxSizeMB
• FileMaxAgeDays
• FileMaxBackups
• FileCompress
• FileMaxQueueSize
• Do not say that queue size can still be configured separately unless you find explicit docs-repo evidence for that.
• Point admins to AdvancedLoggingJSON for audit log file rotation / advanced audit log output behavior.
• Keep scope focused on correcting inaccurate admin config docs.
• Do not modify changelogs, upgrade notes, version archive, deprecated/removed features, or unsupported releases.
• Do not make a decision to delete the experimental docs file unless you find explicit evidence in the docs repo that it is obsolete.

What to do:

• Identify the existing docs pages/sections that still document these removed ExperimentalAuditSettings fields.
• Update those pages to remove or rewrite the outdated settings.
• Replace any inaccurate wording so it does not imply FileMaxQueueSize is still supported there.
• Add a short admin-facing note pointing readers to AdvancedLoggingJSON for audit log rotation and advanced output configuration.
• Keep the update minimal, accurate, and aligned to Mattermost server v11.6.

[claude]

Claude finished @Combs7th's task in 2m 57s —— View job

---

Revised audit log docs — all 5 removed fields addressed

• Read CLAUDE.md for repo-specific guidelines
• Read changed files to understand current state
• Identify all sections documenting the 5 removed ExperimentalAuditSettings fields
• Update environment-configuration-settings.rst — removed FileMaxQueueSize section, expanded existing note to point to AdvancedLoggingJSON for file rotation and advanced output
• Update experimental-configuration-settings.rst — fixed intro text (was "file name and queue size", now "file name only"), removed FileMaxQueueSize section
• Update logging.rst — removed FileMaxQueueSize: 1000 from cloud defaults list
• Update telemetry.rst — removed enum FileMaxQueueSize from ExperimentalAuditSettings telemetry list
• Commit and push changes

---

Summary of changes (commit 5df6d13):

File	Change
environment-configuration-settings.rst	Removed FileMaxQueueSize section; expanded the audit file name note to include: "To configure file rotation and advanced audit log output, use the AdvancedLoggingJSON setting."
experimental-configuration-settings.rst	Fixed intro text (removed "and queue size"); removed Maximum file queue section
logging.rst	Removed FileMaxQueueSize: 1000 from cloud default values list
telemetry.rst	Removed enum FileMaxQueueSize from ExperimentalAuditSettings telemetry list

The previous PR commit had removed the 4 rotation settings (FileMaxSizeMB, FileMaxAgeDays, FileMaxBackups, FileCompress) but missed FileMaxQueueSize in all locations. All 5 fields are now removed in alignment with mattermost/mattermost#35170.
|

[github-actions]

Newest code from mattermost has been published to preview environment for Git SHA 5df6d13

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84352809-c408-4984-aff1-aa1a4ec89bf0

📥 Commits

Reviewing files that changed from the base of the PR and between 5df6d13 and 4af6ca7.

📒 Files selected for processing (1)

• source/administration-guide/manage/telemetry.rst

💤 Files with no reviewable changes (1)

• source/administration-guide/manage/telemetry.rst

---

📝 Walkthrough

Walkthrough

Removed documentation for deprecated self-hosted audit log file rotation settings across configuration pages and updated guidance to direct users to AdvancedLoggingJSON for file rotation and advanced audit-log output. The Telemetry administration guide file was deleted entirely.

Changes

Cohort / File(s)	Summary
Audit Log — environment config source/administration-guide/configure/environment-configuration-settings.rst	Removed auditlog-filemaxsizemb, auditlog-filemaxagedays, auditlog-filemaxbackups, auditlog-filecompress, and auditlog-filemaxqueuesize config docs; added note directing file rotation/advanced audit output to AdvancedLoggingJSON.
Audit Log — experimental config source/administration-guide/configure/experimental-configuration-settings.rst	Removed max-file-size, max-file-age, maximum-file-backups, file-compression, and maximum-file-queue entries; retained only file-name guidance and pointed to AdvancedLoggingJSON.
Logging reference source/administration-guide/manage/logging.rst	Removed default file-related parameters for self-hosted audit logging in Cloud reference, leaving only FileEnabled: false.
Telemetry guide source/administration-guide/manage/telemetry.rst	Deleted the entire Telemetry administration guide file and its detailed telemetry enumerations and descriptions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR addresses issue #8769's main objectives: assessing the necessity of docs updates and identifying/updating admin documentation pages referencing removed audit log settings. However, the deletion of telemetry.rst appears unrelated to the linked issue's scope.	The telemetry.rst deletion contradicts the PR's stated focus and the linked issue's guidance to limit scope to correcting inaccurate admin config docs about audit log rotation. Remove this out-of-scope file deletion.
Out of Scope Changes check	⚠️ Warning	The deletion of source/administration-guide/manage/telemetry.rst is out of scope. The linked issue #8769 focuses on removing audit log file rotation settings documentation, not removing telemetry documentation entirely.	Remove the deletion of telemetry.rst as it is unrelated to the audit log file rotation settings removal objective specified in issue #8769.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Remove unused audit log file rotation settings from docs' clearly and directly summarizes the main change—removal of deprecated audit log file rotation configuration settings documentation.
Description check	✅ Passed	The description is related to the changeset and explains the purpose: removing audit log file rotation settings documentation to reflect Mattermost v11.4+ behaviour, with reference to the engineering PR and related issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/issue-8769-20260304-2307

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

source/administration-guide/manage/telemetry.rst (1)

1-1: ⚠️ Potential issue | 🟡 Minor

Consider broader telemetry documentation strategy.

A previous review comment indicates telemetry is no longer collected ("We don't do telemetry any longer"). Additionally, the changes to this file (removing individual ServiceSettings enumeration fields) appear outside the stated PR scope of removing audit log rotation settings documentation.

Before merging, clarify whether:

1. The entire telemetry file should be deprecated/removed rather than maintained
2. These enum field removals are intentional or accidentally included in this PR

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@source/administration-guide/manage/telemetry.rst` at line 1, The telemetry
docs currently state telemetry is not collected and the diff shows removals from
the ServiceSettings enumeration that fall outside the audit-log-rotation scope;
confirm whether the telemetry page
(source/administration-guide/manage/telemetry.rst) should be fully
deprecated/removed or retained, and if retained revert or remove only the
unrelated enum-field edits (references to ServiceSettings enum fields) so this
PR only contains audit log rotation doc changes; update the PR with either a
removal commit for the telemetry file or a revert/adjustment of the
ServiceSettings field deletions and add a short commit message explaining the
chosen action.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@source/administration-guide/configure/environment-configuration-settings.rst`:
- Line 3592: The sentence that currently reads as an absolute requirement should
be narrowed to apply only when using the FileEnabled/file-output audit logging
path: update the phrasing around the "enable <#auditlog-fileenabled>`__ audit
logging" reference so it explicitly says the file name must be set when using
the FileEnabled (file output) audit logger; leave references to
AdvancedLoggingJSON and ExperimentalAuditSettings.FileName untouched but note
that those targets may not require ExperimentalAuditSettings.FileName. Target
the text around the "enable <#auditlog-fileenabled>" link and mention
"FileEnabled/file-output path" and "ExperimentalAuditSettings.FileName" so
readers understand the requirement is scoped to the file-output configuration
only.

---

Duplicate comments:
In `@source/administration-guide/manage/telemetry.rst`:
- Line 1: The telemetry docs currently state telemetry is not collected and the
diff shows removals from the ServiceSettings enumeration that fall outside the
audit-log-rotation scope; confirm whether the telemetry page
(source/administration-guide/manage/telemetry.rst) should be fully
deprecated/removed or retained, and if retained revert or remove only the
unrelated enum-field edits (references to ServiceSettings enum fields) so this
PR only contains audit log rotation doc changes; update the PR with either a
removal commit for the telemetry file or a revert/adjustment of the
ServiceSettings field deletions and add a short commit message explaining the
chosen action.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2372fab4-159b-42bd-94e7-6267364f6e57

📥 Commits

Reviewing files that changed from the base of the PR and between a35fec9 and 5df6d13.

📒 Files selected for processing (4)

• source/administration-guide/configure/environment-configuration-settings.rst
• source/administration-guide/configure/experimental-configuration-settings.rst
• source/administration-guide/manage/logging.rst
• source/administration-guide/manage/telemetry.rst

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Clarify filename requirement scope for audit logging.

Line 3592 currently states that file name must be set to enable audit logging. That reads as absolute, but audit logging can be configured via AdvancedLoggingJSON targets where ExperimentalAuditSettings.FileName may not be required. Please scope this requirement to the FileEnabled/file-output path only.

Suggested wording

-  The file name must be set to `enable <#auditlog-fileenabled>`__ audit logging. To configure file rotation and advanced audit log output, use the :ref:`AdvancedLoggingJSON <administration-guide/configure/environment-configuration-settings:output audit logs to multiple targets>` setting.
+  When `output audit logs to file <#auditlog-fileenabled>`__ is enabled, the file name must be set. To configure file rotation and advanced audit log output, use the :ref:`AdvancedLoggingJSON <administration-guide/configure/environment-configuration-settings:output audit logs to multiple targets>` setting.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@source/administration-guide/configure/environment-configuration-settings.rst`
at line 3592, The sentence that currently reads as an absolute requirement
should be narrowed to apply only when using the FileEnabled/file-output audit
logging path: update the phrasing around the "enable <#auditlog-fileenabled>`__
audit logging" reference so it explicitly says the file name must be set when
using the FileEnabled (file output) audit logger; leave references to
AdvancedLoggingJSON and ExperimentalAuditSettings.FileName untouched but note
that those targets may not require ExperimentalAuditSettings.FileName. Target
the text around the "enable <#auditlog-fileenabled>" link and mention
"FileEnabled/file-output path" and "ExperimentalAuditSettings.FileName" so
readers understand the requirement is scoped to the file-output configuration
only.

[Combs7th]

@hanzei - Is this looking more accurate now?

[github-actions]

Newest code from mattermost has been published to preview environment for Git SHA 4af6ca7