π¨ Palette: Add contextual ARIA labels to workout exercise action buttons#96
π¨ Palette: Add contextual ARIA labels to workout exercise action buttons#96
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: Added dynamic, contextual
aria-labelattributes to the "History", "Swap exercise", "1RM Calculator", "Plates", and "Note" icon-only buttons in the active workout view (src/pages/workout.js). Additionally, addedaria-hidden="true"to their internal<svg>elements.π― Why: Icon-only buttons without accessible names cannot be understood by screen reader users. Adding dynamic ARIA labels specific to each exercise (e.g., "History for Barbell Back Squat" rather than just "History") ensures screen reader users can uniquely identify which exercise's history or settings they are interacting with when navigating the active workout page. Hiding the
<svg>prevents screen readers from redundantly announcing the image element.πΈ Before/After: No visual changes were made.
βΏ Accessibility: Significantly improves screen reader navigation and experience in the core workout interface by satisfying WCAG 4.1.2 Name, Role, Value.
PR created automatically by Jules for task 7109295696396721783 started by @longestmt