π¨ Palette: Improve screen reader accessibility for workout action buttons#94
π¨ Palette: Improve screen reader accessibility for workout action buttons#94
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: Added highly descriptive
aria-labelattributes to the icon-only action buttons (History, Swap, 1RM Calculator, Plates, Note) and ambiguously named set modification buttons ("+ Set", "β Set") within the workout exercise cards. We now interpolate the specific exercise name (e.g.aria-label="History for Bench Press"). Additionally, addedaria-hidden="true"to the inner decorative<svg>elements.π― Why: Screen reader users navigating a list of exercise cards were previously hearing a repetitive sequence of identical generic buttons like "History button, Swap exercise button". Providing explicit item context allows them to confidently know which exercise they are operating on.
πΈ Before/After: Visual appearance remains exactly the same.
βΏ Accessibility: Massively improves navigation predictability for screen reader users by removing contextless generic action labels on repeated list elements, and correctly hides decorative graphical SVGs.
PR created automatically by Jules for task 16443674044900694375 started by @longestmt