π¨ Palette: Contextual ARIA labels for exercise action buttons#93
π¨ Palette: Contextual ARIA labels for exercise action buttons#93
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: Added specific, contextual
aria-labelattributes to the icon-only action buttons (History, Swap, 1RM, Plates, Note) inside exercise cards on the active workout view, and explicitly hid their inner SVG icons from screen readers.π― Why: Generic icon-only action buttons inside repeated list items or grids create ambiguity for screen reader users, because they don't know which specific item the action applies to (e.g. "History" vs "History for Squat"). Adding explicit, interpolated context prevents this ambiguity.
πΈ Before/After: Visually identical (no screenshot attached).
βΏ Accessibility: Significantly improves screen reader navigation by ensuring all interactive elements have uniquely identifiable names and that decorative SVGs do not create ghost tab stops.
PR created automatically by Jules for task 12008285656433576016 started by @longestmt