Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS via javascript: URIs in anchor tags#92

Open
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-xss-javascript-uris-8199610424774672007
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS via javascript: URIs in anchor tags#92
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-xss-javascript-uris-8199610424774672007

Conversation

@longestmt
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Dynamic URLs (ex.mediaUrl in the Exercise detail view and info.url in the GitHub backup settings) were injected directly into the href attributes of <a> elements without checking for unsafe protocols. This created a vector where malicious javascript: URIs could be executed when clicked, leading to Cross-Site Scripting (XSS).
🎯 Impact: An attacker could craft or manipulate data (e.g., custom exercises, malformed gist backups) containing javascript: payloads. When an unsuspecting user views this data and clicks the link, arbitrary JavaScript could be executed within the application's context, potentially exposing sensitive local storage, tokens, or workout data.
πŸ”§ Fix: Introduced a sanitizeUrl helper function in src/utils/sanitize.js. This function enforces that the URL string strictly begins with http:// or https://. If it doesn't, it safely degrades to #. The helper was then applied to all instances where dynamic, potentially untrusted URLs were assigned to href attributes.
βœ… Verification: A static analysis build (pnpm run build and node -c) succeeded, confirming the syntax and logic. Validated that only standard http/https protocols will successfully render valid URLs in the injected anchor tags.


PR created automatically by Jules for task 8199610424774672007 started by @longestmt

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant