Skip to content

🎨 Palette: Enhance screen reader context for icon-only action buttons#91

Open
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-11260423232709495148
Open

🎨 Palette: Enhance screen reader context for icon-only action buttons#91
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-11260423232709495148

Conversation

@longestmt
Copy link
Copy Markdown
Owner

πŸ’‘ What
Added explicit, context-aware aria-label attributes to the icon-only buttons in the active workout view (History, Swap, 1RM, Plates, Note) and the global modal close button. Also added aria-hidden="true" to the inner decorative <svg> elements.

🎯 Why
Screen readers previously announced these buttons as generic unlabelled buttons, making it impossible for visually impaired users to understand what action they would trigger or which exercise they applied to.

πŸ“Έ Before/After
Visually identical. Dom changes:
<button title="History"><svg/></button>
becomes
<button aria-label="History for Barbell Back Squat" title="History"><svg aria-hidden="true"/></button>

β™Ώ Accessibility

  • Prevents screen readers from getting stuck reading raw SVG paths.
  • Provides immediate, clear context for actions (e.g., "History for Squat" instead of just "History") which is critical in list/grid views with repeating elements.

PR created automatically by Jules for task 11260423232709495148 started by @longestmt

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant