π¨ Palette: Enhance screen reader context for icon-only action buttons#91
π¨ Palette: Enhance screen reader context for icon-only action buttons#91
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What
Added explicit, context-aware
aria-labelattributes to the icon-only buttons in the active workout view (History, Swap, 1RM, Plates, Note) and the global modal close button. Also addedaria-hidden="true"to the inner decorative<svg>elements.π― Why
Screen readers previously announced these buttons as generic unlabelled buttons, making it impossible for visually impaired users to understand what action they would trigger or which exercise they applied to.
πΈ Before/After
Visually identical. Dom changes:
<button title="History"><svg/></button>becomes
<button aria-label="History for Barbell Back Squat" title="History"><svg aria-hidden="true"/></button>βΏ Accessibility
PR created automatically by Jules for task 11260423232709495148 started by @longestmt