Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in exercises library page#87

Open
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-xss-exercises-page-8902295141334438836
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in exercises library page#87
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-xss-exercises-page-8902295141334438836

Conversation

@longestmt
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Cross-Site Scripting (XSS) via unsanitized data injected into DOM innerHTML strings, and missing protocol sanitization on dynamic href properties.
🎯 Impact: Could allow execution of malicious scripts if untrusted exercise data is synced or imported, leading to potential data exfiltration or unauthorized actions in the user's context.
πŸ”§ Fix: Wrapped all dynamic interpolation variables (ex.name, ex.muscleGroup, ex.equipment, ex.category, ex.instructions) with escapeHTML in src/pages/exercises.js and introduced a new sanitizeUrl function to ensure only http/https URLs are allowed in the mediaUrl link. Added security comments for developers.
βœ… Verification: Build succeeds cleanly using pnpm build, no syntax errors verified with node -c.


PR created automatically by Jules for task 8902295141334438836 started by @longestmt

Added `escapeHTML` and `sanitizeUrl` to mitigate XSS vulnerabilities
caused by unsanitized object properties injected directly into the DOM
via template literals in `src/pages/exercises.js`.

The fix prevents `javascript:` URI attacks on the media video button
and protects against injected HTML via exercise names or instructions.

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant