Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability via javascript: URI in href attributes#85

Open
longestmt wants to merge 1 commit intomainfrom
sentinel-href-xss-fix-14440949630535296284
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability via javascript: URI in href attributes#85
longestmt wants to merge 1 commit intomainfrom
sentinel-href-xss-fix-14440949630535296284

Conversation

@longestmt
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Potential XSS vulnerability through javascript: URI injection in user-controllable URLs assigned directly to href attributes (e.g., ex.mediaUrl and info.url).
🎯 Impact: An attacker could execute arbitrary JavaScript in the victim's browser if they click on a maliciously crafted link with a javascript: protocol.
πŸ”§ Fix: Created a sanitizeUrl utility function that strictly enforces http:// or https:// protocols and escapes HTML. Applied this function to dynamic href injections in src/pages/exercises.js and src/pages/settings.js.
βœ… Verification: Ran node -c to verify syntax and pnpm build to ensure the project compiles successfully.


PR created automatically by Jules for task 14440949630535296284 started by @longestmt

… attributes

Added `sanitizeUrl` function to enforce `http://` or `https://` protocols for dynamic URLs injected into `href` attributes, specifically `ex.mediaUrl` and `info.url`, preventing potential XSS attacks via `javascript:` URIs.

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant