π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability via javascript: URI in href attributes#85
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability via javascript: URI in href attributes#85
Conversation
β¦ attributes Added `sanitizeUrl` function to enforce `http://` or `https://` protocols for dynamic URLs injected into `href` attributes, specifically `ex.mediaUrl` and `info.url`, preventing potential XSS attacks via `javascript:` URIs. Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Potential XSS vulnerability through
javascript:URI injection in user-controllable URLs assigned directly tohrefattributes (e.g.,ex.mediaUrlandinfo.url).π― Impact: An attacker could execute arbitrary JavaScript in the victim's browser if they click on a maliciously crafted link with a
javascript:protocol.π§ Fix: Created a
sanitizeUrlutility function that strictly enforceshttp://orhttps://protocols and escapes HTML. Applied this function to dynamichrefinjections insrc/pages/exercises.jsandsrc/pages/settings.js.β Verification: Ran
node -cto verify syntax andpnpm buildto ensure the project compiles successfully.PR created automatically by Jules for task 14440949630535296284 started by @longestmt