Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix URI-based XSS vulnerabilities in dynamic hrefs#83

Open
longestmt wants to merge 1 commit intomainfrom
sentinel-xss-href-mitigation-10207364139024820208
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix URI-based XSS vulnerabilities in dynamic hrefs#83
longestmt wants to merge 1 commit intomainfrom
sentinel-xss-href-mitigation-10207364139024820208

Conversation

@longestmt
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Cross-Site Scripting (XSS) via javascript: URIs being injected into dynamic href attributes (ex.mediaUrl in exercises page and info.url in settings page).
🎯 Impact: An attacker who controls these URLs could execute arbitrary JavaScript in the context of the application when a user clicks the affected links.
πŸ”§ Fix: Introduced a sanitizeUrl utility in src/utils/sanitize.js that strictly validates the URL protocol against an allowlist (http:// or https://) and applies escapeHTML. Applied this utility to all instances where dynamic URLs are interpolated into href attributes.
βœ… Verification:

  1. Ran node -c on modified files to verify syntax.
  2. Ran pnpm build to confirm compilation.
  3. Verified the code handles javascript: protocols by returning an empty string, effectively neutralizing the payload.

PR created automatically by Jules for task 10207364139024820208 started by @longestmt

Added `sanitizeUrl` utility to enforce HTTP/HTTPS protocols and applied it to dynamic URLs injected into href attributes.

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant