Skip to content

🎨 Palette: Enhance accessibility for icon-only buttons#81

Open
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-13488891390287201187
Open

🎨 Palette: Enhance accessibility for icon-only buttons#81
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-13488891390287201187

Conversation

@longestmt
Copy link
Copy Markdown
Owner

πŸ’‘ What

Added aria-label attributes to icon-only buttons and aria-hidden="true" to their internal SVGs or icon characters across src/pages/workout.js, src/pages/plans.js, src/components/modal.js, and src/components/timer.js.

🎯 Why

When buttons only contain visual icons (like SVGs) and lack an explicit text label or aria-label, screen readers often announce them poorly (e.g., as "button" or by reading the SVG's inner code), making the interface difficult to navigate for visually impaired users. Adding aria-label provides a clear, descriptive action, and aria-hidden="true" prevents the screen reader from trying to read the purely visual element.

πŸ“Έ Before/After

Before:
<button class="btn btn-ghost btn-icon" title="History"><svg>...</svg></button>

After:
<button class="btn btn-ghost btn-icon" title="History" aria-label="History"><svg aria-hidden="true">...</svg></button>

β™Ώ Accessibility

This change directly improves accessibility by ensuring all interactive icon-only elements have a meaningful text alternative for assistive technologies, adhering to WCAG guidelines for non-text content.


PR created automatically by Jules for task 13488891390287201187 started by @longestmt

Added `aria-label` to clearly describe the action for screen reader users and `aria-hidden="true"` to the internal SVG or icon element to prevent redundant or confusing graphic announcements. Updated instances across `workout.js`, `plans.js`, `modal.js`, and `timer.js`.

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant