Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in href injection#80

Open
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-href-xss-12402462297349079819
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in href injection#80
longestmt wants to merge 1 commit intomainfrom
sentinel/fix-href-xss-12402462297349079819

Conversation

@longestmt
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: A Cross-Site Scripting (XSS) vulnerability was found where dynamically generated href attributes (ex.mediaUrl in src/pages/exercises.js and info.url in src/pages/settings.js) could execute malicious JavaScript if a user supplied a javascript: protocol URI. escapeHTML alone does not protect against this as javascript: URIs do not necessarily contain HTML special characters.
🎯 Impact: An attacker could inject a malicious URL into the database (e.g., via sync or import), causing arbitrary JavaScript execution when a user clicks the "Watch Video" or "View Gist" links.
πŸ”§ Fix: Added a sanitizeUrl function in src/utils/sanitize.js to explicitly validate that URLs start with http:// or https:// before escaping them. Applied this function to the relevant href injections in src/pages/exercises.js and src/pages/settings.js.
βœ… Verification: Verified the application builds successfully (pnpm build) and unit tests pass (node --test). Added a journal entry detailing the learning and prevention strategy.


PR created automatically by Jules for task 12402462297349079819 started by @longestmt

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant