π¨ Palette: Add missing ARIA labels to icon-only buttons#79
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What
Added missing
aria-labelattributes to icon-only buttons across the application (workout view, plan builder, modal, and rest timer), and addedaria-hidden="true"to their inner SVG icons.π― Why
In Vanilla JS apps built with template strings, icon-only buttons that rely solely on
titleattributes are often poorly announced or skipped by screen readers. Furthermore, inline SVGs can sometimes be read as garbled text or cause confusion if not explicitly hidden from assistive technologies. This ensures critical UI actions (delete, edit, skip timer, close modal) are fully accessible to screen reader users.πΈ Before/After
No visual changes. This is a purely structural accessibility improvement.
βΏ Accessibility
aria-labelattributes corresponding to button functions.aria-hidden="true"to SVG elements within these buttons to prevent redundant/confusing announcements.PR created automatically by Jules for task 7376246487896471006 started by @longestmt