π¨ Palette: Improve accessibility of icon-only buttons#76
π¨ Palette: Improve accessibility of icon-only buttons#76
Conversation
Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: Added explicit
aria-labelattributes to icon-only buttons across the application (like Close, Delete, Start, History, Swap, Note) and addedaria-hidden="true"to their internal<svg>elements.π― Why: Icon-only buttons without accessible names cannot be interpreted correctly by screen readers, creating a significant barrier for visually impaired users. Additionally, reading out the raw SVG contents is confusing. This change ensures screen readers correctly announce the button's purpose while ignoring the visual SVG markup.
πΈ Before/After: Visual appearance is completely unchanged, but the accessibility tree is significantly improved.
βΏ Accessibility:
aria-labelattribute to icon-only buttons insrc/components/modal.js,src/pages/plans.js, andsrc/pages/workout.js.aria-hidden="true"to internal<svg>elements to prevent redundant or confusing screen reader announcements.PR created automatically by Jules for task 5219097353689213210 started by @longestmt