Skip to content

🎨 Palette: Improve accessibility of icon-only buttons#76

Open
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-5219097353689213210
Open

🎨 Palette: Improve accessibility of icon-only buttons#76
longestmt wants to merge 1 commit intomainfrom
palette/a11y-icon-buttons-5219097353689213210

Conversation

@longestmt
Copy link
Copy Markdown
Owner

πŸ’‘ What: Added explicit aria-label attributes to icon-only buttons across the application (like Close, Delete, Start, History, Swap, Note) and added aria-hidden="true" to their internal <svg> elements.

🎯 Why: Icon-only buttons without accessible names cannot be interpreted correctly by screen readers, creating a significant barrier for visually impaired users. Additionally, reading out the raw SVG contents is confusing. This change ensures screen readers correctly announce the button's purpose while ignoring the visual SVG markup.

πŸ“Έ Before/After: Visual appearance is completely unchanged, but the accessibility tree is significantly improved.

β™Ώ Accessibility:

  • Adds aria-label attribute to icon-only buttons in src/components/modal.js, src/pages/plans.js, and src/pages/workout.js.
  • Adds aria-hidden="true" to internal <svg> elements to prevent redundant or confusing screen reader announcements.

PR created automatically by Jules for task 5219097353689213210 started by @longestmt

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant