π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in exercise URLs#75
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in exercise URLs#75
Conversation
- Sanitize dynamic `href` attribute `ex.mediaUrl` by validating it starts with `http://` or `https://` before escaping. - Apply `escapeHTML` to `ex.name`, `ex.muscleGroup`, `ex.equipment`, `ex.category`, and `ex.instructions` when interpolated into `innerHTML`. - Add Sentinel journal entry for XSS via `javascript:` URIs. Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Cross-Site Scripting (XSS) vulnerability was found in
src/pages/exercises.jswhere user-provided exercise properties (specificallymediaUrl) were injected directly into DOMinnerHTMLattributes without protocol validation, allowingjavascript:URI-based execution. Other properties were also missing basicescapeHTMLsanitization.π― Impact: If a malicious user imports an exercise or synchronization pulls a corrupted entry with a
javascript:URL, executing the media link could trigger arbitrary script execution within the context of the user's local instance.π§ Fix: Implemented protocol validation to ensure
mediaUrlexplicitly starts withhttp://orhttps://before applyingescapeHTML. Additionally, wrappedex.name,ex.muscleGroup,ex.equipment,ex.category, andex.instructionsinescapeHTML. Documented thejavascript:URI bypass logic in the Sentinel journal.β Verification: Code logic confirmed by visual review and
node -c src/pages/exercises.js. Application builds correctly withpnpm build.PR created automatically by Jules for task 17361104265065323669 started by @longestmt