Skip to content

🎨 Palette: Add for attributes to form labels for accessibility#73

Open
longestmt wants to merge 1 commit intomainfrom
palette-label-for-attributes-1093018293492573387
Open

🎨 Palette: Add for attributes to form labels for accessibility#73
longestmt wants to merge 1 commit intomainfrom
palette-label-for-attributes-1093018293492573387

Conversation

@longestmt
Copy link
Copy Markdown
Owner

πŸ’‘ What: Added for attributes to <label> elements pointing to the id of their respective input, select, or textarea fields.

🎯 Why: In many forms where a generic <label> element is placed visually near an input, screen readers do not automatically associate the label with the input. The <label> element needs a for attribute that strictly matches the id of the input element it represents to provide context for screen reader users and to expand the clickable area to focus the input.

πŸ“Έ Before/After: Visually identical. HTML structure improved for screen readers.

β™Ώ Accessibility: Significant improvement. Form fields are now properly linked to their descriptive labels, allowing screen readers to accurately read the input label when navigating form fields.

Journaled this learning in .Jules/palette.md.


PR created automatically by Jules for task 1093018293492573387 started by @longestmt

Added `for` attributes to `<label>` elements pointing to the `id` of their respective inputs to ensure screen reader association. Updated components:
- `src/components/rm-calculator.js`
- `src/components/plate-calc.js`
- `src/pages/workout.js`
- `src/pages/exercises.js`
- `src/pages/plans.js`
- `src/pages/settings.js`

Documented the learning in `.Jules/palette.md`.

Co-authored-by: longestmt <1509654+longestmt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant