Skip to content

test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unnawut merged 3 commits into from
Mar 17, 2026
Merged

test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot #457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41c2d51
add gossip_proposer_attestation to fix test_reorg_on_newly_justified_…
unnawut Mar 17, 2026
1ce57d8
formatting
unnawut Mar 17, 2026
7d0cc8e
readd comment removed by mistake
unnawut Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions tests/consensus/devnet/fc/test_fork_choice_reorgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ def test_reorg_on_newly_justified_slot(
steps=[
# Common base at slot 1
BlockStep(
block=BlockSpec(slot=Slot(1), label="base"),
block=BlockSpec(slot=Slot(1), label="base", gossip_proposer_attestation=True),
checks=StoreChecks(
head_slot=Slot(1),
head_root_label="base",
Expand All @@ -873,7 +873,12 @@ def test_reorg_on_newly_justified_slot(
# Fork A: slot 2
# Fork A is the heaviest chain (1 block from justified slot)
BlockStep(
block=BlockSpec(slot=Slot(2), parent_label="base", label="fork_a_1"),
block=BlockSpec(
slot=Slot(2),
parent_label="base",
label="fork_a_1",
gossip_proposer_attestation=True,
),
checks=StoreChecks(
head_slot=Slot(2),
head_root_label="fork_a_1",
Expand All @@ -882,7 +887,12 @@ def test_reorg_on_newly_justified_slot(
# Fork A: slot 3
# Fork A is the heaviest chain (2 blocks from justified slot)
BlockStep(
block=BlockSpec(slot=Slot(3), parent_label="fork_a_1", label="fork_a_2"),
block=BlockSpec(
slot=Slot(3),
parent_label="fork_a_1",
label="fork_a_2",
gossip_proposer_attestation=True,
),
checks=StoreChecks(
head_slot=Slot(3),
head_root_label="fork_a_2",
Expand All @@ -891,7 +901,12 @@ def test_reorg_on_newly_justified_slot(
# Fork A: slot 4
# Fork A is the heaviest chain (3 blocks from justified slot)
BlockStep(
block=BlockSpec(slot=Slot(4), parent_label="fork_a_2", label="fork_a_3"),
block=BlockSpec(
slot=Slot(4),
parent_label="fork_a_2",
label="fork_a_3",
gossip_proposer_attestation=True,
),
checks=StoreChecks(
head_slot=Slot(4),
head_root_label="fork_a_3",
Expand All @@ -900,7 +915,12 @@ def test_reorg_on_newly_justified_slot(
# Fork B: slot 5 (first block of fork B)
# Fork A is still the heaviest chain (3 blocks from justified slot)
BlockStep(
block=BlockSpec(slot=Slot(5), parent_label="base", label="fork_b_1"),
block=BlockSpec(
slot=Slot(5),
parent_label="base",
label="fork_b_1",
gossip_proposer_attestation=True,
),
checks=StoreChecks(
head_slot=Slot(4),
head_root_label="fork_a_3",
Expand Down
Loading