Skip to content

test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot#457

Merged
unnawut merged 3 commits intoleanEthereum:mainfrom
unnawut:fix-vectors
Mar 17, 2026
Merged

test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot#457
unnawut merged 3 commits intoleanEthereum:mainfrom
unnawut:fix-vectors

Conversation

@unnawut
Copy link
Collaborator

@unnawut unnawut commented Mar 17, 2026

🗒️ Description

A test vector (test_reorg_on_newly_justified_slot) is still failing even after the key regen in #455. This is caused by a spec's behavior change in #449 where we no longer embed the proposer's attestation as part of the block proposal (they're now gossiped like non-proposer's attestations) so a block proposal no longer carries 1 attestation weight from the proposer so fork A never gets any fork choice weight (so it was using lexicographical order hence the random pass/failure).

This PR is a quick fix to get the test vectors working again. A better solution might be to make gossip_proposer_attestation=True the default behavior for all test cases but that's a much bigger change.

✅ Checklist

  • Ran tox checks to avoid unnecessary CI fails:
    uvx tox
    
  • Considered adding appropriate tests for the changes.
  • Considered updating the online docs in the ./docs/ directory.

Copy link
Collaborator

@Kayden-ML Kayden-ML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@unnawut unnawut changed the title add gossip_proposer_attestation to fix test_reorg_on_newly_justified_slot test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot Mar 17, 2026
@unnawut unnawut merged commit a5df895 into leanEthereum:main Mar 17, 2026
12 checks passed
@unnawut unnawut deleted the fix-vectors branch March 17, 2026 10:41
@unnawut unnawut added the tests Scope: Changes to the spec tests label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Scope: Changes to the spec tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants