feat(FR-2183): add filtering, sorting, pagination and fix schema alignment#6108
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.74% (-0.01% 🔻) |
1543/17645 |
| 🔴 | Branches | 7.55% (-0% 🔻) |
930/12310 |
| 🔴 | Functions | 5.65% (-0% 🔻) |
278/4922 |
| 🔴 | Lines | 8.42% (-0.01% 🔻) |
1446/17176 |
Test suite run success
784 tests passing in 37 suites.
Report generated by 🧪jest coverage report action from 60bce64
26bf665 to
1de318f
Compare
There was a problem hiding this comment.
Pull request overview
Enhances MyKeypairManagementModal to support server-driven filtering, sorting, and pagination for the myKeypairs (v2) GraphQL query, while also aligning UI/API usage with Ant Design v6 and the current GraphQL schema.
Changes:
- Removed redundant
@since(version: "26.4.0")directives from the keypair mutations andmyKeypairsquery call site. - Added
BAIGraphQLPropertyFilter-based filtering (accessKey/resourcePolicy),KeypairOrderBysorting viaconvertToOrderBy, and offset pagination viauseBAIPaginationOptionState. - Enabled BAITable column settings (visibility overrides) and fixed
Alertprop usage (message→title) for antd v6.
1de318f to
cc1268a
Compare
99adf1e to
8def885
Compare
2d8eba3 to
6508023
Compare
8def885 to
678a3f6
Compare
6508023 to
fab56c9
Compare
678a3f6 to
5905b70
Compare
fab56c9 to
635d79b
Compare
635d79b to
9b3d28b
Compare
5905b70 to
563651c
Compare
9b3d28b to
09a5beb
Compare
45a68b2 to
a08439f
Compare
52d0bd4 to
25e99a1
Compare
a08439f to
7a85d82
Compare
25e99a1 to
f484f68
Compare
f484f68 to
d1fec43
Compare
7a85d82 to
a09e43d
Compare
d1fec43 to
d4bbc67
Compare
a09e43d to
567b4b1
Compare
d4bbc67 to
70e8bdc
Compare
6d04f7a to
add6761
Compare
4ad6472 to
8563814
Compare
8563814 to
b2484e1
Compare
b2484e1 to
e41e7d5
Compare
add6761 to
744792f
Compare
744792f to
48bde00
Compare
e41e7d5 to
655e6a2
Compare
…nment Resolves #6097(FR-2183) - Remove redundant @SInCE(version: "26.4.0") directives from all mutations and the main query (parent component already gates on version) - Fix Alert message prop to title (antd v6) - Add BAIGraphQLPropertyFilter for accessKey and resourcePolicy - Add column sorting via KeypairOrderBy with convertToOrderBy helper - Add offset-based pagination using useBAIPaginationOptionState - Add BAITable column settings with tableSettings prop - Preserve filter/sort state across tab switches - Reset pagination to page 1 on filter/tab changes
655e6a2 to
60bce64
Compare


Resolves #6097(FR-2183)
How to test
my-keypairs)Summary
@since(version: "26.4.0")directives from all mutations and the main query (parent component already gates on version compatibility)messageprop totitle(antd v6 API)BAIGraphQLPropertyFilterforaccessKeyandresourcePolicystring filtersKeypairOrderByusingconvertToOrderByhelper (default:CREATED_ATDESC)useBAIPaginationOptionStatewith server-sidecounttableSettingspropmy-keypairsfeature flag tosupports()registry inbackend.ai-client-esm.ts(gated at 26.4.0)baiClient?.supports('my-keypairs')instead ofisManagerVersionCompatibleWith('26.4.0')inUserSettingsPage.tsxChanged Files
react/src/components/MyKeypairManagementModal.tsxsrc/lib/backend.ai-client-esm.tsreact/src/pages/UserSettingsPage.tsxNotes
createdAt/lastUseddatetime filters are not added becauseKeypairFilterin the current schema only supportsaccessKey,isActive,isAdmin,resourcePolicyfieldsissueMyKeypairandupdateMyKeypairmutation return types match the current local schema; if the backend schema is updated (PR #10415), those mutations will need a follow-up updateVerification