Skip to content

feat(FR-2183): add filtering, sorting, pagination and fix schema alignment#6108

Open
agatha197 wants to merge 1 commit into03-23-feat_fr-2183_add_set_as_main_and_deactivate_actions_for_active_tabfrom
03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment
Open

feat(FR-2183): add filtering, sorting, pagination and fix schema alignment#6108
agatha197 wants to merge 1 commit into03-23-feat_fr-2183_add_set_as_main_and_deactivate_actions_for_active_tabfrom
03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Mar 23, 2026

Resolves #6097(FR-2183)

How to test

  • Downgrade version of esm file for testing. (my-keypairs)
  • Go to usersettings page
  • Click config button of My Keypair Information

Summary

  • Remove redundant @since(version: "26.4.0") directives from all mutations and the main query (parent component already gates on version compatibility)
  • Fix Alert message prop to title (antd v6 API)
  • Add BAIGraphQLPropertyFilter for accessKey and resourcePolicy string filters
  • Add column sorting via KeypairOrderBy using convertToOrderBy helper (default: CREATED_AT DESC)
  • Add offset-based pagination using useBAIPaginationOptionState with server-side count
  • Add BAITable column settings button via tableSettings prop
  • Preserve filter/sort state across tab switches; reset pagination on filter/tab changes
  • Add my-keypairs feature flag to supports() registry in backend.ai-client-esm.ts (gated at 26.4.0)
  • Use baiClient?.supports('my-keypairs') instead of isManagerVersionCompatibleWith('26.4.0') in UserSettingsPage.tsx

Changed Files

  • react/src/components/MyKeypairManagementModal.tsx
  • src/lib/backend.ai-client-esm.ts
  • react/src/pages/UserSettingsPage.tsx

Notes

  • createdAt/lastUsed datetime filters are not added because KeypairFilter in the current schema only supports accessKey, isActive, isAdmin, resourcePolicy fields
  • issueMyKeypair and updateMyKeypair mutation return types match the current local schema; if the backend schema is updated (PR #10415), those mutations will need a follow-up update

Verification

bash scripts/verify.sh

Copy link
Copy Markdown
Contributor Author

agatha197 commented Mar 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.74% (-0.01% 🔻)
1543/17645
🔴 Branches
7.55% (-0% 🔻)
930/12310
🔴 Functions
5.65% (-0% 🔻)
278/4922
🔴 Lines
8.42% (-0.01% 🔻)
1446/17176

Test suite run success

784 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 60bce64

@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 26bf665 to 1de318f Compare March 23, 2026 09:47
@github-actions github-actions bot added the area:lib Library and SDK related issue. label Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enhances MyKeypairManagementModal to support server-driven filtering, sorting, and pagination for the myKeypairs (v2) GraphQL query, while also aligning UI/API usage with Ant Design v6 and the current GraphQL schema.

Changes:

  • Removed redundant @since(version: "26.4.0") directives from the keypair mutations and myKeypairs query call site.
  • Added BAIGraphQLPropertyFilter-based filtering (accessKey/resourcePolicy), KeypairOrderBy sorting via convertToOrderBy, and offset pagination via useBAIPaginationOptionState.
  • Enabled BAITable column settings (visibility overrides) and fixed Alert prop usage (messagetitle) for antd v6.

@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 1de318f to cc1268a Compare March 25, 2026 11:37
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch 2 times, most recently from 99adf1e to 8def885 Compare March 25, 2026 11:51
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch 2 times, most recently from 2d8eba3 to 6508023 Compare March 25, 2026 11:55
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from 8def885 to 678a3f6 Compare March 25, 2026 11:55
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 6508023 to fab56c9 Compare March 25, 2026 11:58
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from 678a3f6 to 5905b70 Compare March 25, 2026 11:58
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from fab56c9 to 635d79b Compare March 25, 2026 12:06
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Mar 25, 2026
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 635d79b to 9b3d28b Compare March 25, 2026 12:19
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from 5905b70 to 563651c Compare March 25, 2026 12:59
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 9b3d28b to 09a5beb Compare March 25, 2026 12:59
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from 45a68b2 to a08439f Compare March 27, 2026 05:12
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 52d0bd4 to 25e99a1 Compare March 27, 2026 05:12
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from a08439f to 7a85d82 Compare March 27, 2026 05:44
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 25e99a1 to f484f68 Compare March 27, 2026 05:44
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align components.
image.png

@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from f484f68 to d1fec43 Compare March 27, 2026 07:42
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from 7a85d82 to a09e43d Compare March 27, 2026 07:42
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from d1fec43 to d4bbc67 Compare March 27, 2026 07:52
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch from a09e43d to 567b4b1 Compare March 27, 2026 07:52
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from d4bbc67 to 70e8bdc Compare March 27, 2026 07:54
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab branch 2 times, most recently from 6d04f7a to add6761 Compare March 27, 2026 08:34
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch 2 times, most recently from 4ad6472 to 8563814 Compare March 27, 2026 08:39
@agatha197 agatha197 requested a review from ironAiken2 March 27, 2026 08:39
@agatha197 agatha197 marked this pull request as draft March 27, 2026 08:42
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 8563814 to b2484e1 Compare March 27, 2026 08:52
@agatha197 agatha197 requested a review from Copilot March 27, 2026 08:52
@agatha197 agatha197 marked this pull request as ready for review March 27, 2026 08:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

@agatha197 agatha197 changed the base branch from 03-23-feat_fr-2183_add_activate_and_delete_actions_for_inactive_tab to graphite-base/6108 March 27, 2026 14:44
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from b2484e1 to e41e7d5 Compare March 27, 2026 15:25
@agatha197 agatha197 force-pushed the graphite-base/6108 branch from add6761 to 744792f Compare March 27, 2026 15:25
@agatha197 agatha197 changed the base branch from graphite-base/6108 to 03-23-feat_fr-2183_add_set_as_main_and_deactivate_actions_for_active_tab March 27, 2026 15:25
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_set_as_main_and_deactivate_actions_for_active_tab branch from 744792f to 48bde00 Compare March 27, 2026 15:28
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from e41e7d5 to 655e6a2 Compare March 27, 2026 15:28
…nment

Resolves #6097(FR-2183)

- Remove redundant @SInCE(version: "26.4.0") directives from all mutations
  and the main query (parent component already gates on version)
- Fix Alert message prop to title (antd v6)
- Add BAIGraphQLPropertyFilter for accessKey and resourcePolicy
- Add column sorting via KeypairOrderBy with convertToOrderBy helper
- Add offset-based pagination using useBAIPaginationOptionState
- Add BAITable column settings with tableSettings prop
- Preserve filter/sort state across tab switches
- Reset pagination to page 1 on filter/tab changes
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_add_filtering_sorting_pagination_and_fix_schema_alignment branch from 655e6a2 to 60bce64 Compare March 27, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants