Skip to content

feat(FR-2183): rename MyKeypairInfoModal to legacy and add @since branching#6099

Open
agatha197 wants to merge 1 commit into03-17-feat_fr-2183_add_keypair_self-service_management_feature_specfrom
03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching
Open

feat(FR-2183): rename MyKeypairInfoModal to legacy and add @since branching#6099
agatha197 wants to merge 1 commit into03-17-feat_fr-2183_add_keypair_self-service_management_feature_specfrom
03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Mar 23, 2026

Resolves #6092(FR-2183)

Changes

  • Rename MyKeypairInfoModal.tsx to MyKeypairInfoModalLegacy.tsx with TODO comment for removal after 27.4.0
  • Add placeholder MyKeypairManagementModal.tsx for backend >= 26.4.0
  • In UserSettingsPage.tsx, use baiClient.isManagerVersionCompatibleWith('26.4.0') to conditionally render the new management modal or the legacy modal

Verification

bash scripts/verify.sh=== ALL PASS ===

Checklist: (if applicable)

  • Documentation
  • Minimum required manager version (26.4.0 for new modal)
  • Specific setting for review
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copilot AI review requested due to automatic review settings March 23, 2026 08:42
@github-actions github-actions bot added the size:M 30~100 LoC label Mar 23, 2026
Copy link
Copy Markdown
Contributor Author

agatha197 commented Mar 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.81% (-0% 🔻)
1543/17517
🔴 Branches
7.58% (-0% 🔻)
930/12268
🔴 Functions
5.7% (-0% 🔻)
278/4881
🔴 Lines
8.48% (-0% 🔻)
1446/17048
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / MyKeypairManagementModal.tsx
0% 100% 0% 0%
🔴
... / MyKeypairInfoModalLegacy.tsx
0% 0% 0% 0%

Test suite run success

784 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 02dd7f0

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces manager-version branching for the “My keypair info” modal in the user settings page by keeping the existing implementation as a legacy modal and routing newer managers to a new (future) management modal.

Changes:

  • Renamed the existing keypair info modal into a legacy component and updated the Relay query name accordingly.
  • Added a new MyKeypairManagementModal component and switched UserSettingsPage to conditionally render legacy vs. new modal based on manager version compatibility.
  • Added useSuspendedBackendaiClient() usage in UserSettingsPage to drive the version gate.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
react/src/pages/UserSettingsPage.tsx Adds manager-version gate to choose between legacy info modal and new management modal.
react/src/components/MyKeypairManagementModal.tsx Introduces a new (currently placeholder) modal for keypair management on newer managers.
react/src/components/MyKeypairInfoModalLegacy.tsx Renames the old modal + Relay query type/name to “Legacy” for backward compatibility.

@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from f0d6dee to c5b404c Compare March 25, 2026 11:37
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 762ed83 to 13c511b Compare March 25, 2026 11:37
@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from c5b404c to a8f4281 Compare March 26, 2026 07:15
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 13c511b to 1b80210 Compare March 26, 2026 07:15
@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from a8f4281 to f1fe63b Compare March 26, 2026 07:19
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 1b80210 to 2dd7d3b Compare March 26, 2026 07:19
@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from f1fe63b to ccf9f6d Compare March 26, 2026 08:29
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 2dd7d3b to 72522aa Compare March 26, 2026 08:29
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from ccf9f6d to 8c54740 Compare March 27, 2026 04:33
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 72522aa to 4d0cedd Compare March 27, 2026 04:33
@github-actions github-actions bot added the area:lib Library and SDK related issue. label Mar 27, 2026
@agatha197 agatha197 requested a review from nowgnuesLee March 27, 2026 04:33
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from 8c54740 to e189759 Compare March 27, 2026 07:42
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 4d0cedd to 18630cf Compare March 27, 2026 07:42
@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from e189759 to 43f62a6 Compare March 27, 2026 10:24
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 18630cf to 33330a8 Compare March 27, 2026 10:24
@agatha197 agatha197 force-pushed the 03-17-feat_fr-2183_add_keypair_self-service_management_feature_spec branch from 43f62a6 to 7b17ce1 Compare March 27, 2026 14:44
@agatha197 agatha197 force-pushed the 03-23-feat_fr-2183_rename_mykeypairinfomodal_to_legacy_and_add_since_branching branch from 33330a8 to 02dd7f0 Compare March 27, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:lib Library and SDK related issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants