feat(FR-2183): rename MyKeypairInfoModal to legacy and add @since branching#6099
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.81% (-0% 🔻) |
1543/17517 |
| 🔴 | Branches | 7.58% (-0% 🔻) |
930/12268 |
| 🔴 | Functions | 5.7% (-0% 🔻) |
278/4881 |
| 🔴 | Lines | 8.48% (-0% 🔻) |
1446/17048 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / MyKeypairManagementModal.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / MyKeypairInfoModalLegacy.tsx |
0% | 0% | 0% | 0% |
Test suite run success
784 tests passing in 37 suites.
Report generated by 🧪jest coverage report action from 02dd7f0
There was a problem hiding this comment.
Pull request overview
This PR introduces manager-version branching for the “My keypair info” modal in the user settings page by keeping the existing implementation as a legacy modal and routing newer managers to a new (future) management modal.
Changes:
- Renamed the existing keypair info modal into a legacy component and updated the Relay query name accordingly.
- Added a new
MyKeypairManagementModalcomponent and switchedUserSettingsPageto conditionally render legacy vs. new modal based on manager version compatibility. - Added
useSuspendedBackendaiClient()usage inUserSettingsPageto drive the version gate.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| react/src/pages/UserSettingsPage.tsx | Adds manager-version gate to choose between legacy info modal and new management modal. |
| react/src/components/MyKeypairManagementModal.tsx | Introduces a new (currently placeholder) modal for keypair management on newer managers. |
| react/src/components/MyKeypairInfoModalLegacy.tsx | Renames the old modal + Relay query type/name to “Legacy” for backward compatibility. |
f0d6dee to
c5b404c
Compare
762ed83 to
13c511b
Compare
c5b404c to
a8f4281
Compare
13c511b to
1b80210
Compare
a8f4281 to
f1fe63b
Compare
1b80210 to
2dd7d3b
Compare
f1fe63b to
ccf9f6d
Compare
2dd7d3b to
72522aa
Compare
ccf9f6d to
8c54740
Compare
72522aa to
4d0cedd
Compare
8c54740 to
e189759
Compare
4d0cedd to
18630cf
Compare
e189759 to
43f62a6
Compare
18630cf to
33330a8
Compare
43f62a6 to
7b17ce1
Compare
33330a8 to
02dd7f0
Compare

Resolves #6092(FR-2183)
Changes
MyKeypairInfoModal.tsxtoMyKeypairInfoModalLegacy.tsxwith TODO comment for removal after 27.4.0MyKeypairManagementModal.tsxfor backend >= 26.4.0UserSettingsPage.tsx, usebaiClient.isManagerVersionCompatibleWith('26.4.0')to conditionally render the new management modal or the legacy modalVerification
bash scripts/verify.sh→=== ALL PASS ===Checklist: (if applicable)