Use bitemporal_id as primary key for Rails 8+ AR::Batches#251
Merged
Conversation
Collaborator
|
The value retrieved here was the value of the Consequently, the value passed to the subsequent condition did not match the column. |
kymmt90
added a commit
that referenced
this pull request
Apr 9, 2026
`excluding` / `without` internally calls `predicate_builder[primary_key, records]` to build a NOT IN clause. Without the primary_key override, this generates `WHERE id NOT IN (...)` instead of `WHERE bitemporal_id NOT IN (...)`, causing incorrect record exclusion for bitemporal models with history. This is the same class of issue fixed in PR #251 for AR::Batches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since ar-bitemporal 7.0.0 changed the effective primary key back to
id,find_each,find_in_batches, andin_batchesuse the model'sidas the cursor column in Rails 8+. This results in a mismatch between the primary key (id) and the value used in cursor conditions (bitemporal_id).This problem may cause the same record to be read repeatedly when batching is needed.
Solution
This PR applies
use_bitemporal_id_as_primary_keyto the three batch methods. This ensures the cursor column resolves tobitemporal_idfor the duration of each batch call.