Use bitemporal_id as primary key for Rails 8+ excluding/without #252
Merged
Use bitemporal_id as primary key for Rails 8+ excluding/without #252
Conversation
`excluding` / `without` internally calls `predicate_builder[primary_key, records]` to build a NOT IN clause. Without the primary_key override, this generates `WHERE id NOT IN (...)` instead of `WHERE bitemporal_id NOT IN (...)`, causing incorrect record exclusion for bitemporal models with history. This is the same class of issue fixed in PR #251 for AR::Batches. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the same problem as #251, but for AR::QueryMethods#excluding and #without.