Skip to content

Rename default catalog sources ConfigMap to default-catalog-sources #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mturley wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Rename default catalog sources ConfigMap to default-catalog-sources #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/ui/bff/internal/integrations/kubernetes/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const ComponentLabelValue = "model-registry"
const ComponentLabelValueCatalog = "model-catalog"

const CatalogSourceKey = "sources.yaml"
const CatalogSourceDefaultConfigMapName = "model-catalog-default-sources"
const CatalogSourceDefaultConfigMapName = "default-catalog-sources"
const CatalogSourceUserConfigMapName = "model-catalog-sources"

type KubernetesClientInterface interface {
Expand Down
2 changes: 1 addition & 1 deletion clients/ui/bff/internal/integrations/kubernetes/k8mocks/base_testenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ catalogs:
}

if _, err := k8sClient.CoreV1().ConfigMaps(namespace).Create(ctx, cm, metav1.CreateOptions{}); err != nil {
return fmt.Errorf("failed to create model-catalog-default-sources configmap: %w", err)
return fmt.Errorf("failed to create default-catalog-sources configmap: %w", err)
}

return nil
Expand Down
4 changes: 2 additions & 2 deletions manifests/kustomize/options/catalog/overlays/odh/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ configMapGenerator:
- behavior: create
files:
- sources.yaml=default-sources.yaml
name: model-catalog-default-sources
name: default-catalog-sources
options:
disableNameSuffixHash: true

Expand All @@ -34,7 +34,7 @@ patches:
value:
name: default-sources
configMap:
name: model-catalog-default-sources
name: default-catalog-sources
- op: add
path: /spec/template/spec/containers/0/volumeMounts/1
value:
Expand Down
Loading