Rename default catalog sources ConfigMap to default-catalog-sources#2593
Open
mturley wants to merge 1 commit intokubeflow:mainfrom
Open
Rename default catalog sources ConfigMap to default-catalog-sources#2593mturley wants to merge 1 commit intokubeflow:mainfrom
default-catalog-sources#2593mturley wants to merge 1 commit intokubeflow:mainfrom
Conversation
The operator renamed the ConfigMap from model-catalog-default-sources to default-catalog-sources in model-registry-operator#489, but the BFF and kustomize manifests were not updated, causing a 500 error on the Model Catalog Settings page. Ref: RHOAIENG-57824 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
mturley
changed the title
default-catalog-sources
Contributor
Author
|
/hold |
pboyd
reviewed
Apr 14, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pboyd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the default catalog sources ConfigMap from
model-catalog-default-sourcestodefault-catalog-sourcesto align with the naming convention established in the ODH downstream's model-registry-operator by opendatahub-io/model-registry-operator#489 .Updates:
CatalogSourceDefaultConfigMapNameconstant in the BFFHow Has This Been Tested?
go test ./clients/ui/bff/internal/integrations/kubernetes/... -count=1)Merge criteria:
ok-to-testhas been added to the PR.